Bug 135610 - fast/ruby/ruby-svg-crash.html is flaky
Summary: fast/ruby/ruby-svg-crash.html is flaky
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-05 10:04 PDT by Michal Pakula vel Rutka
Modified: 2015-01-01 00:04 PST (History)
6 users (show)

See Also:

Attachments
proposed fix (3.16 KB, patch)
2014-12-31 18:44 PST, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Pakula vel Rutka 2014-08-05 10:04:09 PDT 
fast/ruby/ruby-svg-crash.html is flaky, when failing there is an additional line with right bracket in the output:

@@ -1 +1,2 @@
-This succeeds if this test doesn't crash.
+This succeeds if this test doesn't crash. 
+>
Comment 1 Alexey Proskuryakov 2014-12-31 12:53:07 PST 
Same on Mac.
Comment 2 Alexey Proskuryakov 2014-12-31 18:44:26 PST 
Created attachment 243855 [details]
proposed fix

This failure means that notifyDone() is called before the main test function executes.

I'm not sure what exactly happens here. There are two possible mechanisms for the failure:

1. DOMContentLoaded fires substantially later than the inline script is executed. If parsing pauses right after </script>, that's quite possible.

2. Two chained zero-delay timers take longer than a 10 ms timer. I don't know if that's possible in WebCore.
Comment 3 WebKit Commit Bot 2015-01-01 00:04:08 PST 
Comment on attachment 243855 [details]
proposed fix

Clearing flags on attachment: 243855

Committed r177842: <http://trac.webkit.org/changeset/177842>
Comment 4 WebKit Commit Bot 2015-01-01 00:04:12 PST 
All reviewed patches have been landed.  Closing bug.