Bug 135597 - Replace swap() methods on HashTable and related classes with std::swap()
Summary: Replace swap() methods on HashTable and related classes with std::swap()
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-05 00:15 PDT by Zan Dobersek
Modified: 2014-11-02 03:08 PST (History)
15 users (show)

See Also:

Attachments
Patch (33.76 KB, patch)
2014-08-05 00:29 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (33.73 KB, patch)
2014-08-05 00:39 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (35.77 KB, patch)
2014-08-05 11:25 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (36.33 KB, patch)
2014-08-06 06:55 PDT, Zan Dobersek 		bfulgham: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2014-08-05 00:15:33 PDT 
Replace swap() methods on HashTable and related classes with std::swap()
Comment 1 Zan Dobersek 2014-08-05 00:29:02 PDT 
Created attachment 236015 [details]
Patch
Comment 2 WebKit Commit Bot 2014-08-05 00:31:43 PDT 
Attachment 236015 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 28 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Zan Dobersek 2014-08-05 00:39:42 PDT 
Created attachment 236016 [details]
Patch
Comment 4 Zan Dobersek 2014-08-05 11:25:47 PDT 
Created attachment 236036 [details]
Patch
Comment 5 Zan Dobersek 2014-08-06 06:55:12 PDT 
Created attachment 236099 [details]
Patch
Comment 6 Brent Fulgham 2014-10-31 12:40:38 PDT 
Comment on attachment 236099 [details]
Patch

What a great cleanup! It looks like the EFL failure is simply due to the EWS bot being in a bad state. r=me.
Comment 7 Alexey Proskuryakov 2014-10-31 15:01:16 PDT 
Actually, looks like Efl bot complained about something related to this patch - it was in a bad state before, but not when it finished.
Comment 8 Zan Dobersek 2014-11-02 03:08:11 PST 
Thanks for the review.

The patch is outdated at this point, so I'll update it and also have a look at the failure on the EFL EWS.