Bug 135585 – [GTK] [CSS Shapes] Layout test fast/shapes/shape-outside-floats/shape-outside-image-shape-margin.html fails

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Carlos Alberto Lopez Perez]

The layout test fast/shapes/shape-outside-floats/shape-outside-image-shape-margin.html added on r172010 <http://trac.webkit.org/changeset/172010> fails on GTK:

fast/shapes/shape-outside-floats/shape-outside-image-shape-margin.html [ ImageOnlyFailure ]

Failure: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r172010%20%281886%29/fast/shapes/shape-outside-floats/shape-outside-image-shape-margin-diffs.html

[Carlos Alberto Lopez Perez]

I have added this test to the list of expected failures for GTK on https://trac.webkit.org/r172017. Please remove it from the list if you fix the issue. Thanks

[Bem Jones-Bey]

Created attachment 236045 [details]
Patch

This should fix the issue, but I have not been able to test it on a GTK build yet, if someone can do that, it would be great, otherwise I'll update when I have a working Linux GTK build.

[Bem Jones-Bey]

Comment on attachment 236045 [details]
Patch

This does fix it in my GTK build.

[Carlos Alberto Lopez Perez]

(In reply to comment #3)
> (From update of attachment 236045 [details])
> This does fix it in my GTK build.

Yes. I confirm that this patch fixes the issue on the GTK build.

I'm not a reviewer, but hopefully one will look into it soon :)

Thanks

[Zoltan Horvath]

Comment on attachment 236045 [details]
Patch

(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 236045 [details] [details])
> > This does fix it in my GTK build.
> 
> Yes. I confirm that this patch fixes the issue on the GTK build.
> 
> I'm not a reviewer, but hopefully one will look into it soon :)
> 
> Thanks

Thanks for checking!

[WebKit Commit Bot]

Comment on attachment 236045 [details]
Patch

Clearing flags on attachment: 236045

Committed r172116: <http://trac.webkit.org/changeset/172116>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.