<rdar://problem/17837636>
Created attachment 235993 [details] patch
Comment on attachment 235993 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=235993&action=review > Source/WebCore/editing/SelectionRectGatherer.cpp:56 > + absoluteGapRects.uniteLeft(LayoutRect(repaintContainer->localToAbsoluteQuad(FloatQuad(rects.left())).boundingBox())); > + absoluteGapRects.uniteCenter(LayoutRect(repaintContainer->localToAbsoluteQuad(FloatQuad(rects.center())).boundingBox())); > + absoluteGapRects.uniteRight(LayoutRect(repaintContainer->localToAbsoluteQuad(FloatQuad(rects.right())).boundingBox())); This is all gross and horrible and services should not be so tied to selection code.
(In reply to comment #2) > (From update of attachment 235993 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=235993&action=review > > > Source/WebCore/editing/SelectionRectGatherer.cpp:56 > > + absoluteGapRects.uniteLeft(LayoutRect(repaintContainer->localToAbsoluteQuad(FloatQuad(rects.left())).boundingBox())); > > + absoluteGapRects.uniteCenter(LayoutRect(repaintContainer->localToAbsoluteQuad(FloatQuad(rects.center())).boundingBox())); > > + absoluteGapRects.uniteRight(LayoutRect(repaintContainer->localToAbsoluteQuad(FloatQuad(rects.right())).boundingBox())); > > This is all gross and horrible and services should not be so tied to selection code. +1 Thank you. http://trac.webkit.org/changeset/172013
Created attachment 235997 [details] crash fix
Comment on attachment 235997 [details] crash fix Good boy!
Stop the crashes: http://trac.webkit.org/changeset/172018