Bug 135581 - SSO expects to be able to walk parent application's bundle
Summary: SSO expects to be able to walk parent application's bundle
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-04 16:59 PDT by Oliver Hunt
Modified: 2014-08-05 09:42 PDT (History)
5 users (show)

See Also:

Attachments
Patch (8.99 KB, patch)
2014-08-04 17:02 PDT, Oliver Hunt 		no flags Details | Formatted Diff | Diff
Patch (10.30 KB, patch)
2014-08-04 17:06 PDT, Oliver Hunt 		ap: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2014-08-04 16:59:40 PDT 
SSO expects to be able to walk parent application's bundle
Comment 1 Oliver Hunt 2014-08-04 17:02:11 PDT 
Created attachment 235991 [details]
Patch
Comment 2 Oliver Hunt 2014-08-04 17:06:49 PDT 
Created attachment 235992 [details]
Patch
Comment 3 Alexey Proskuryakov 2014-08-04 17:13:27 PDT 
Comment on attachment 235992 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235992&action=review

Weird, but OK.

> Source/WebKit2/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:32
> -;; FIXME: Remove the webkti specific extension classes <rdar://problem/17755931>
> +;; FIXME: Remove the webkit specific extension classes <rdar://problem/17755931>

Do we actually have any of those?

> Source/WebKit2/UIProcess/mac/WebContextMac.mm:326
> +String WebContext::platformDefaultParentBundleDirectory() const

I'm still very annoyed by this seemingly cross platform code being added only for iOS. These functions should be completely inside PLATFORM(IOS) checks, having them defined with a broken fallback behavior is misleading and unhelpful.
Comment 4 Oliver Hunt 2014-08-05 09:42:10 PDT 
Committed r172031: <http://trac.webkit.org/changeset/172031>