Bug 135573 - AX: isWordEndMatch should allow for multiple word selections
Summary: AX: isWordEndMatch should allow for multiple word selections
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: chris fleizach
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-08-04 13:50 PDT by chris fleizach
Modified: 2014-08-04 14:56 PDT (History)
2 users (show)

See Also:

Attachments
patch (5.92 KB, patch)
2014-08-04 14:37 PDT, chris fleizach 		mario: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2014-08-04 13:50:47 PDT 
The recently added isWordEndMatch method only works when the checked match has one word in it.

But if you have a multiple word match, it will find the first word break and then return that.

So the fix should be to search from the end of the string to find if we're at the end. We already matched everything up to the end as part of the finding process before that.
Comment 1 Radar WebKit Bug Importer 2014-08-04 13:51:02 PDT 
<rdar://problem/17906689>
Comment 2 chris fleizach 2014-08-04 14:37:29 PDT 
Created attachment 235985 [details]
patch
Comment 3 chris fleizach 2014-08-04 14:56:36 PDT 
http://trac.webkit.org/changeset/172005