Bug 135554 - Enable didReceiveDataArray callback on Mac
Summary: Enable didReceiveDataArray callback on Mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pratik Solanki
URL:
Keywords: InRadar
Depends on: 135727
Blocks:
  Show dependency tree / graph
 
Reported: 2014-08-03 22:15 PDT by Pratik Solanki
Modified: 2014-08-12 16:46 PDT (History)
4 users (show)

See Also:

Attachments
Patch for bots (1.34 KB, patch)
2014-08-03 22:19 PDT, Pratik Solanki 		no flags Details | Formatted Diff | Diff
Patch (1.47 KB, patch)
2014-08-07 19:57 PDT, Pratik Solanki 		kling: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pratik Solanki 2014-08-03 22:15:40 PDT 
iOS uses didReceiveDataArray callback while Mac uses didReceiveData. It would be nice to make the two platforms consistent. didReceiveDataArray callback is better since it reduces a copying phase in CFNetwork.

<rdar://problem/9170731>
Comment 1 Pratik Solanki 2014-08-03 22:19:50 PDT 
Created attachment 235960 [details]
Patch for bots
Comment 2 Pratik Solanki 2014-08-07 15:10:12 PDT 
Uncovered bug 135727 when looking at the memory impact of this change.
Comment 3 Pratik Solanki 2014-08-07 19:57:32 PDT 
Created attachment 236255 [details]
Patch
Comment 4 Andreas Kling 2014-08-08 14:30:28 PDT 
Comment on attachment 236255 [details]
Patch

r=me
Comment 5 Pratik Solanki 2014-08-11 12:21:35 PDT 
Thanks for the review. I'll check this in after bug 135727.
Comment 6 Pratik Solanki 2014-08-12 16:46:08 PDT 
Committed r172508: <http://trac.webkit.org/changeset/172508>