Bug 135527 - commit-log-editor uses a non-standard message format when git index contains no ChangeLog changes
Summary: commit-log-editor uses a non-standard message format when git index contains ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-01 15:55 PDT by mitz
Modified: 2014-08-01 16:11 PDT (History)
2 users (show)

See Also:


Attachments
Apply commit message formatting to prepared ChangeLog entries (12.70 KB, patch)
2014-08-01 16:05 PDT, mitz
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2014-08-01 15:55:40 PDT
In a git repository, if the git index contains no changes to ChanegLog files, commit-log-editor prepares a commit message that is straight prepare-ChangeLog output, including 8-space indentation and date + author headers.
Comment 1 mitz 2014-08-01 16:05:23 PDT
Created attachment 235918 [details]
Apply commit message formatting to prepared ChangeLog entries
Comment 2 Tim Horton 2014-08-01 16:06:57 PDT
Comment on attachment 235918 [details]
Apply commit message formatting to prepared ChangeLog entries

View in context: https://bugs.webkit.org/attachment.cgi?id=235918&action=review

> Tools/ChangeLog:10
> +        the --delimiters option the prepare-ChangeLog, then process each entry in the output using

s/the/to/?
Comment 3 mitz 2014-08-01 16:10:36 PDT
(In reply to comment #2)
> (From update of attachment 235918 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=235918&action=review
> 
> > Tools/ChangeLog:10
> > +        the --delimiters option the prepare-ChangeLog, then process each entry in the output using
> 
> s/the/to/?

Yes!
Comment 4 mitz 2014-08-01 16:11:21 PDT
Fixed in <http://trac.webkit.org/r171954>.