Bug 135526 – Native inlining in FTL should not require three compiles of the same files

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Matthew Mirman]

Patch forthcoming

[Matthew Mirman]

Created attachment 235925 [details]
Merges the two inlining passes

Also adds the AvailableExternallyLinkage assertion

[Matthew Mirman]

Created attachment 236781 [details]
Merges the two inlining passes

Now intended for trunk branch.

[Oliver Hunt]

Comment on attachment 236781 [details]
Merges the two inlining passes

Im not incredibly happy about making everything non-static - why is this necessary? Can we not make clang emit ir for static methods?

[WebKit Commit Bot]

Attachment 236781 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/JSDataViewPrototype.cpp:66:  The parameter name "exec" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/build-symbol-table-index.py:52:  missing whitespace around operator  [pep8/E225] [5]
Total errors found: 2 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Filip Pizlo]

Comment on attachment 236781 [details]
Merges the two inlining passes

r=me

[Matthew Mirman]

(In reply to comment #3)
> (From update of attachment 236781 [details])
> Im not incredibly happy about making everything non-static - why is this necessary? Can we not make clang emit ir for static methods?

The problem is not that clang can't emit IR, the problem is that the other IR that clang emits makes calls to those static methods, and when we inline it, we need to call out to those methods, which must not be private since they are no longer only being called from the same file.

[Matthew Mirman]

Landed in http://trac.webkit.org/changeset/172756

[Csaba Osztrogonác]

(In reply to comment #7)
> Landed in http://trac.webkit.org/changeset/172756

And EFL buildfix landed in https://trac.webkit.org/changeset/172793.

( Just a note: It wasn't a fairplay game to land the patch
when the EFL noticed the build breakage ahead of time. :-/ )

[Matthew Mirman]

Created attachment 237168 [details]
Merges the two inlining passes

[Matthew Mirman]

Comment on attachment 237168 [details]
Merges the two inlining passes

Erroneous patch.