WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
135523
Add some structure related assertions
https://bugs.webkit.org/show_bug.cgi?id=135523
Summary
Add some structure related assertions
Mark Lam
Reported
2014-08-01 15:33:46 PDT
Adding 2 assertions: 1. assert that we don't index pass the end of the StructureIDTable. This should never happen, but this assertion will help catch bugs where a bad structureID gets passed in. 2. assert that cells in MarkedBlock::callDestructor() that are not zapped should have a non-null StructureID. This will help us catch bugs where the other cell header flag bits get set after the cell is zapped, thereby making the cell look like an unzapped cell but has a null structureID.
Attachments
the patch
(2.23 KB, patch)
2014-08-01 15:38 PDT
,
Mark Lam
ggaren
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mark Lam
Comment 1
2014-08-01 15:38:16 PDT
Created
attachment 235910
[details]
the patch
Geoffrey Garen
Comment 2
2014-08-01 15:41:05 PDT
Comment on
attachment 235910
[details]
the patch r=me
Mark Lam
Comment 3
2014-08-01 15:50:50 PDT
Thanks. Landed in
r171953
: <
http://trac.webkit.org/r171953
>.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug