Bug 135511 – REGRESSION (r169357): Disabling "allow plug-ins" doesn't stick on quit/relaunch

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

<rdar://problem/17862013>

When opening Safari, the Allow Plug-ins option in preferences is enabled, even if it has been previously disabled.

This was caused by <http://trac.webkit.org/r169357>.

Created attachment 235892 [details]
Respect user defaults when overrides are registered

[Alexey Proskuryakov]

Comment on attachment 235892 [details]
Respect user defaults when overrides are registered

View in context: https://bugs.webkit.org/attachment.cgi?id=235892&action=review

Nice.

> Source/WebKit2/UIProcess/mac/WebPreferencesMac.mm:62
> +    if (!m_identifier)
> +        return false;

I don't understand this addition, didn't we use to assert in makeKey? Why does this need to be a runtime check?

Comment on attachment 235892 [details]
Respect user defaults when overrides are registered

View in context: https://bugs.webkit.org/attachment.cgi?id=235892&action=review

>> Source/WebKit2/UIProcess/mac/WebPreferencesMac.mm:62
>> +        return false;
> 
> I don't understand this addition, didn't we use to assert in makeKey? Why does this need to be a runtime check?

registerDefaultBoolValueForKey calls platformGetBoolUserValueForKey even if the identifier is empty. I guess I could have added the checks there, but it seems logical to handle the no-identifier (and therefore no user defaults) case here.

Fixed in <http://trac.webkit.org/r171928>.