WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
135505
[GTK] Be able to disable gtk2 dependency
https://bugs.webkit.org/show_bug.cgi?id=135505
Summary
[GTK] Be able to disable gtk2 dependency
Milan Crha
Reported
2014-08-01 06:19:53 PDT
Please add a configure option to be able to disable gtk2 dependency. It's not good to mix gtk3 and gtk2 (I build webkitgtk for gtk3), and it's sometimes not needed (like for evolution). If you can enable it by default, but allow a configure option to disable it, then it'll help to build softer webkit (like under Win32, I know, I know, webkit2 doesn't work right now, but let's start with small steps). It's understood that disable of the gtk2 dependency removes some functionality, like the famous flash, but that's understood and fine.
Attachments
Add an option to disable WebKitPluginProcess2
(6.39 KB, patch)
2014-08-04 02:47 PDT
,
Carlos Garcia Campos
gustavo
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1
2014-08-01 06:22:07 PDT
Now that the default plugin process doesn't use GTK2, it's possible to build without gtk2 support. And of course GTK+2 plugins like flash would not work.
Carlos Garcia Campos
Comment 2
2014-08-04 02:47:27 PDT
Created
attachment 235969
[details]
Add an option to disable WebKitPluginProcess2 WebKitPluginProcess2 is the only reason we depend on GTK+2.
Gustavo Noronha (kov)
Comment 3
2014-08-06 07:18:59 PDT
Comment on
attachment 235969
[details]
Add an option to disable WebKitPluginProcess2 View in context:
https://bugs.webkit.org/attachment.cgi?id=235969&action=review
> Source/WebKit2/PlatformGTK.cmake:-580 > - list(APPEND PluginProcessGTK2_INCLUDE_DIRECTORIES > - "${WEBKIT2_DIR}/PluginProcess/unix" > - ) > - > - include_directories(${PluginProcessGTK2_INCLUDE_DIRECTORIES})
This path is already added on a more general basis, I imagine?
Carlos Garcia Campos
Comment 4
2014-08-06 07:57:43 PDT
Comment on
attachment 235969
[details]
Add an option to disable WebKitPluginProcess2 View in context:
https://bugs.webkit.org/attachment.cgi?id=235969&action=review
>> Source/WebKit2/PlatformGTK.cmake:-580 >> - include_directories(${PluginProcessGTK2_INCLUDE_DIRECTORIES}) > > This path is already added on a more general basis, I imagine?
Yes, see the previous chunk
Carlos Garcia Campos
Comment 5
2014-08-06 08:01:54 PDT
Committed
r172144
: <
http://trac.webkit.org/changeset/172144
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug