RESOLVED FIXED 135490
Web Inspector: "Stop Recording" button feels unresponsive, recording takes a long time to stop 
https://bugs.webkit.org/show_bug.cgi?id=135490
Summary Web Inspector: "Stop Recording" button feels unresponsive, recording takes a ...
Joseph Pecoraro
Reported 2014-07-31 18:59:32 PDT
* SUMMARY We recently changed "Stop Recording" button to wait for a "recordingStopped" event from the backend to stop. However, this can produce a very large delay between the time the user clicked "Stop Recording" to when the frontend gets the event. This is especially bad in remote debugging, e.g. with iOS. We should have the UI immediately stop recording and ignore future events. This was the behavior before r171195. * STEPS TO REPRODUCE 1. Load <http://apple.com> in remote target 2. Inspect remote target 3. Reload via inspector 4. Quickly click the record button to "Stop Recording" => recording continues for a couple seconds <rdar://problem/17872655>
Attachments
[PATCH] Proposed Fix (1.83 KB, patch)
2014-07-31 19:02 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2014-07-31 19:02:13 PDT
Created attachment 235870 [details] [PATCH] Proposed Fix
Timothy Hatcher
Comment 2 2014-07-31 20:34:53 PDT
Comment on attachment 235870 [details] [PATCH] Proposed Fix Good call.
WebKit Commit Bot
Comment 3 2014-07-31 21:07:26 PDT
Comment on attachment 235870 [details] [PATCH] Proposed Fix Clearing flags on attachment: 235870 Committed r171908: <http://trac.webkit.org/changeset/171908>
WebKit Commit Bot
Comment 4 2014-07-31 21:07:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.