Bug 135490 - Web Inspector: "Stop Recording" button feels unresponsive, recording takes a long time to stop
Summary: Web Inspector: "Stop Recording" button feels unresponsive, recording takes a ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-07-31 18:59 PDT by Joseph Pecoraro
Modified: 2014-07-31 21:07 PDT (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.83 KB, patch)
2014-07-31 19:02 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-07-31 18:59:32 PDT 
* SUMMARY
We recently changed "Stop Recording" button to wait for a "recordingStopped" event from the backend to stop. However, this can produce a very large delay between the time the user clicked "Stop Recording" to when the frontend gets the event. This is especially bad in remote debugging, e.g. with iOS.

We should have the UI immediately stop recording and ignore future events. This was the behavior before r171195.

* STEPS TO REPRODUCE
1. Load <http://apple.com> in remote target
2. Inspect remote target
3. Reload via inspector
4. Quickly click the record button to "Stop Recording"
  => recording continues for a couple seconds

<rdar://problem/17872655>
Comment 1 Joseph Pecoraro 2014-07-31 19:02:13 PDT 
Created attachment 235870 [details]
[PATCH] Proposed Fix
Comment 2 Timothy Hatcher 2014-07-31 20:34:53 PDT 
Comment on attachment 235870 [details]
[PATCH] Proposed Fix

Good call.
Comment 3 WebKit Commit Bot 2014-07-31 21:07:26 PDT 
Comment on attachment 235870 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 235870

Committed r171908: <http://trac.webkit.org/changeset/171908>
Comment 4 WebKit Commit Bot 2014-07-31 21:07:29 PDT 
All reviewed patches have been landed.  Closing bug.