WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
135489
Remove the JSC::OverridesVisitChildren flag.
https://bugs.webkit.org/show_bug.cgi?id=135489
Summary
Remove the JSC::OverridesVisitChildren flag.
Andreas Kling
Reported
2014-07-31 18:44:19 PDT
The OverridesVisitChildren flag is used to annotate that a JSCell subclass overrides the visitChildren() call via the method table. However, this flag is not actually used by anything other than assertions. I think we can remove it, since it contributes a fair amount of LOC. Doing so will also free up one inline flag bit in JSCell.
Attachments
Proposed patch
(63.95 KB, patch)
2014-07-31 18:46 PDT
,
Andreas Kling
ggaren
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Andreas Kling
Comment 1
2014-07-31 18:46:21 PDT
Created
attachment 235869
[details]
Proposed patch
Geoffrey Garen
Comment 2
2014-08-01 11:48:56 PDT
Comment on
attachment 235869
[details]
Proposed patch r=me
Andreas Kling
Comment 3
2014-08-01 12:03:13 PDT
Committed
r171939
: <
http://trac.webkit.org/changeset/171939
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug