Bug 135489 - Remove the JSC::OverridesVisitChildren flag.
Summary: Remove the JSC::OverridesVisitChildren flag.
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
Depends on:
Reported: 2014-07-31 18:44 PDT by Andreas Kling
Modified: 2014-08-01 12:03 PDT (History)
7 users (show)

See Also:

Proposed patch (63.95 KB, patch)
2014-07-31 18:46 PDT, Andreas Kling
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-07-31 18:44:19 PDT
The OverridesVisitChildren flag is used to annotate that a JSCell subclass overrides the visitChildren() call via the method table.

However, this flag is not actually used by anything other than assertions. I think we can remove it, since it contributes a fair amount of LOC.
Doing so will also free up one inline flag bit in JSCell.
Comment 1 Andreas Kling 2014-07-31 18:46:21 PDT
Created attachment 235869 [details]
Proposed patch
Comment 2 Geoffrey Garen 2014-08-01 11:48:56 PDT
Comment on attachment 235869 [details]
Proposed patch

Comment 3 Andreas Kling 2014-08-01 12:03:13 PDT
Committed r171939: <http://trac.webkit.org/changeset/171939>