Bug 135471 – CodeBlock fails to visit the Executables of its InlineCallFrames

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Hahnenberg]

This leads to crashes after these Executables are prematurely deleted and then accessed later.

[Mark Hahnenberg]

Created attachment 235840 [details]
Patch

[Geoffrey Garen]

Comment on attachment 235840 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235840&action=review

> Source/JavaScriptCore/bytecode/CodeOrigin.h:153
>              return jsCast<JSFunction*>(calleeRecovery.constant());
>          return 0;
>      }
> +
> +    void visitAggregate(SlotVisitor& visitor)
> +    {
> +        visitor.append(&executable);
> +    }

This poor second-class class can probably be a first-class class in its own header. That way, we provide upward mobility inside our code base.

[Geoffrey Garen]

Comment on attachment 235840 [details]
Patch

Clearing flags on attachment: 235840

Committed r171946: <http://trac.webkit.org/changeset/171946>

[Geoffrey Garen]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

(In reply to comment #3)
> (From update of attachment 235840 [details])
> Clearing flags on attachment: 235840
> 
> Committed r171946: <http://trac.webkit.org/changeset/171946>

It broke the non Apple builds as the EWS noticed it. Thanks. :-/
Buildfix landed in http://trac.webkit.org/changeset/171949.