Bug 135464 - [Win] Fix build failure when using 5-tuple build versions
Summary: [Win] Fix build failure when using 5-tuple build versions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-07-31 10:38 PDT by Brent Fulgham
Modified: 2014-07-31 11:01 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.99 KB, patch)
2014-07-31 10:42 PDT, Brent Fulgham
ddkilzer: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2014-07-31 10:38:31 PDT
The VersionStamper tool throws an exception when the RC_PROJECTSOURCEVERSION environment variable contains more than three tuples, even when specific build arguments are given to it.

To avoid the problem, temporarily set the RC_PROJECTSOURCEVERSION, RC_ProjectSourceVersion, and RC_PROJECTBUILDVERSION environment variables to safe/valid 3-tuple versions of the 5-tuple information before invoking the version stamping tool.
Comment 1 Brent Fulgham 2014-07-31 10:39:05 PDT
Tested on builds with invalid RC_PROJECTSOURCEVERSION, RC_ProjectSourceVersion, and RC_PROJECTBUILDVERSION environment variables set.
Comment 2 Brent Fulgham 2014-07-31 10:42:37 PDT
Created attachment 235830 [details]
Patch
Comment 3 Radar WebKit Bug Importer 2014-07-31 10:44:28 PDT
<rdar://problem/17872457>
Comment 4 Radar WebKit Bug Importer 2014-07-31 10:46:18 PDT
<rdar://problem/17872507>
Comment 5 David Kilzer (:ddkilzer) 2014-07-31 10:53:18 PDT
Comment on attachment 235830 [details]
Patch

r=me
Comment 6 Brent Fulgham 2014-07-31 11:01:09 PDT
Committed r171870: <http://trac.webkit.org/changeset/171870>