Bug 135463 – Fix unintentional integer overflow before widen

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[[e-mail]]

Overflowing expression is evaluated using operands arithmetic but then is used in
context which expects an wider integer type. To avoid overflow at least one operand
has to be representative of the wider type.

[[e-mail]]

Created attachment 235828 [details]
porposed patch

[WebKit Commit Bot]

Attachment 235828 [details] did not pass style-queue:


ERROR: Source/WebCore/loader/FTPDirectoryParser.cpp:508:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[[e-mail]]

(In reply to comment #2)
> Attachment 235828 [details] did not pass style-queue:
> 
> 
> ERROR: Source/WebCore/loader/FTPDirectoryParser.cpp:508:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> Total errors found: 1 in 6 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

Whole file is written using 2-space indent.

[Darin Adler]

Comment on attachment 235828 [details]
porposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235828&action=review

> Source/WebCore/loader/FTPDirectoryParser.cpp:508
> -              uint64_t size = strtoul(tokens[1], NULL, 10) * 512;
> +              uint64_t size = strtoull(tokens[1], 0, 10) * 512;

The style checker told you to change the NULL to a 0, but really we would like to use nullptr here.

> Source/WebCore/loader/ProgressTracker.cpp:237
> +    estimatedBytesForPendingRequests = static_cast<long long>(progressItemDefaultEstimatedLength) * numPendingOrLoadingRequests;

A better change would be to change type of progressItemDefaultEstimatedLength from int to long long instead of adding the cast here.

[WebKit Commit Bot]

Comment on attachment 235828 [details]
porposed patch

Clearing flags on attachment: 235828

Committed r172725: <http://trac.webkit.org/changeset/172725>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.