Bug 135462 - Fix resource leak in FillLayersPropertyWrapper object member
Summary: Fix resource leak in FillLayersPropertyWrapper object member
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-31 06:51 PDT by przemeks@pkuczynski.com
Modified: 2014-08-01 17:00 PDT (History)
6 users (show)

See Also:

Attachments
porposed patch (1.77 KB, patch)
2014-07-31 06:53 PDT, przemeks@pkuczynski.com 		no flags Details | Formatted Diff | Diff
Patch (3.00 KB, patch)
2014-08-01 11:50 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description przemeks@pkuczynski.com 2014-07-31 06:51:33 PDT 
Despite allocating memory in constructor, m_fillLayerPropertyWrapper is never freed
causing memory leak.
Comment 1 przemeks@pkuczynski.com 2014-07-31 06:53:35 PDT 
Created attachment 235827 [details]
porposed patch
Comment 2 Simon Fraser (smfr) 2014-07-31 08:43:18 PDT 
Comment on attachment 235827 [details]
porposed patch

This should use std::unique_ptr<>
Comment 3 Simon Fraser (smfr) 2014-08-01 11:50:05 PDT 
Created attachment 235897 [details]
Patch
Comment 4 WebKit Commit Bot 2014-08-01 17:00:43 PDT 
Comment on attachment 235897 [details]
Patch

Clearing flags on attachment: 235897

Committed r171960: <http://trac.webkit.org/changeset/171960>
Comment 5 WebKit Commit Bot 2014-08-01 17:00:50 PDT 
All reviewed patches have been landed.  Closing bug.