Bug 135456 - [EFL] remove ewk_defines.h
Summary: [EFL] remove ewk_defines.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-31 04:43 PDT by Ryuan Choi
Modified: 2014-07-31 19:18 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.31 KB, patch)
2014-07-31 04:44 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2014-07-31 04:43:18 PDT 
ewk_defines.h mentioned "Defines the Ewk Structs", but it just only defines Ewk_Context_Menu and Ewk_Context_Menu_Item.
Comment 1 Ryuan Choi 2014-07-31 04:44:57 PDT 
Created attachment 235818 [details]
Patch
Comment 2 Gyuyoung Kim 2014-07-31 05:13:09 PDT 
Comment on attachment 235818 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235818&action=review

> Source/WebKit2/ChangeLog:3
> +        [EFL] remove ewk_defines.h

IIRC, ewk_defines.h was added because there was circular include chain problem in ewk. Is there no the problem now ?
Comment 3 Ryuan Choi 2014-07-31 05:34:29 PDT 
(In reply to comment #2)
> (From update of attachment 235818 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=235818&action=review
> 
> > Source/WebKit2/ChangeLog:3
> > +        [EFL] remove ewk_defines.h
> 
> IIRC, ewk_defines.h was added because there was circular include chain problem in ewk. Is there no the problem now ?

right, there are circular include issue because both ewk_context_menu.h and ewk_context_menu_item.h requires Ewk_Context_Menu and Ewk_Context_Menu_Item.

In order to avoid it, this patch just declares them to ewk_context_menu_item.h and let ewk_context.h include ewk_context_menu.h instead of using ewk_defines.h.
Comment 4 Ryuan Choi 2014-07-31 19:18:26 PDT 
Comment on attachment 235818 [details]
Patch

Clearing flags on attachment: 235818

Committed r171901: <http://trac.webkit.org/changeset/171901>
Comment 5 Ryuan Choi 2014-07-31 19:18:36 PDT 
All reviewed patches have been landed.  Closing bug.