RESOLVED FIXED Bug 135456
[EFL] remove ewk_defines.h 
https://bugs.webkit.org/show_bug.cgi?id=135456
Summary [EFL] remove ewk_defines.h
Ryuan Choi
Reported 2014-07-31 04:43:18 PDT
ewk_defines.h mentioned "Defines the Ewk Structs", but it just only defines Ewk_Context_Menu and Ewk_Context_Menu_Item.
Attachments
Patch (4.31 KB, patch)
2014-07-31 04:44 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2014-07-31 04:44:57 PDT
Created attachment 235818 [details] Patch
Gyuyoung Kim
Comment 2 2014-07-31 05:13:09 PDT
Comment on attachment 235818 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235818&action=review > Source/WebKit2/ChangeLog:3 > + [EFL] remove ewk_defines.h IIRC, ewk_defines.h was added because there was circular include chain problem in ewk. Is there no the problem now ?
Ryuan Choi
Comment 3 2014-07-31 05:34:29 PDT
(In reply to comment #2) > (From update of attachment 235818 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=235818&action=review > > > Source/WebKit2/ChangeLog:3 > > + [EFL] remove ewk_defines.h > > IIRC, ewk_defines.h was added because there was circular include chain problem in ewk. Is there no the problem now ? right, there are circular include issue because both ewk_context_menu.h and ewk_context_menu_item.h requires Ewk_Context_Menu and Ewk_Context_Menu_Item. In order to avoid it, this patch just declares them to ewk_context_menu_item.h and let ewk_context.h include ewk_context_menu.h instead of using ewk_defines.h.
Ryuan Choi
Comment 4 2014-07-31 19:18:26 PDT
Comment on attachment 235818 [details] Patch Clearing flags on attachment: 235818 Committed r171901: <http://trac.webkit.org/changeset/171901>
Ryuan Choi
Comment 5 2014-07-31 19:18:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.