WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
135441
[iOS] run-webkit-tests: defaults for --runtime and --device-type flags
https://bugs.webkit.org/show_bug.cgi?id=135441
Summary
[iOS] run-webkit-tests: defaults for --runtime and --device-type flags
David Farler
Reported
2014-07-30 17:05:21 PDT
CoreSimulator identifiers are a mouthful - provide some defaults for most situations based on the latest runtime available in the current SDK and a default device based on architecture.
Attachments
Patch
(6.71 KB, patch)
2014-08-05 18:05 PDT
,
David Farler
thorton
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
David Farler
Comment 1
2014-08-05 18:05:30 PDT
Created
attachment 236067
[details]
Patch
David Farler
Comment 2
2014-08-05 18:06:08 PDT
That brings it down to: Tools/Scripts/run-webkit-tests --ios-sim —debug or Tools/Scripts/run-webkit-tests --ios-sim —release
Tim Horton
Comment 3
2014-08-05 18:11:20 PDT
Comment on
attachment 236067
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=236067&action=review
> Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:289 > + optparse.make_option('--device-type', help='iOS Simulator device type identifier (default: i386: iPhone 5, x86_64: iPhone 5s)'),
maybe -> arrows instead of colons for the mapping?
David Farler
Comment 4
2014-08-05 18:37:56 PDT
Good call, that’s a lot of :
David Farler
Comment 5
2014-08-05 18:38:22 PDT
Committed
r172117
: <
http://trac.webkit.org/changeset/172117
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug