Bug 135432 - Web Inspector: console.profile missing profile information
Summary: Web Inspector: console.profile missing profile information
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-07-30 15:17 PDT by Joseph Pecoraro
Modified: 2014-07-31 10:35 PDT (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (9.15 KB, patch)
2014-07-30 15:29 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-07-30 15:17:39 PDT 
* SUMMARY
Switching console.profile to use the Timelines instead of the older ProfilerAgent, we have to remember to tell JSC to recompile functions as soon as WebCore has changed the "supportsProfiling" status. Previously the profiler was always on when the inspector is open. We should go back to that.

* STEPS TO REPRODUCE
1. Inspect http://www.webkit.org/misc/drosera/
2. Click "Nested functions" which does a console.profile
3. View JavaScript & Events timeline in inspector
  => should show "rot" function, but currently does not
Comment 1 Joseph Pecoraro 2014-07-30 15:29:02 PDT 
Created attachment 235771 [details]
[PATCH] Proposed Fix
Comment 2 Timothy Hatcher 2014-07-30 17:12:02 PDT 
Comment on attachment 235771 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=235771&action=review

> Source/WebCore/inspector/InspectorTimelineAgent.h:285
> +    int m_recordingProfileDepth;

ptrdiff_t! :)

Or size_t and just assert that m_recordingProfileDepth > 0 before --m_recordingProfileDepth.
Comment 3 Radar WebKit Bug Importer 2014-07-31 10:19:16 PDT 
<rdar://problem/17872082>
Comment 4 WebKit Commit Bot 2014-07-31 10:35:08 PDT 
Comment on attachment 235771 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 235771

Committed r171866: <http://trac.webkit.org/changeset/171866>
Comment 5 WebKit Commit Bot 2014-07-31 10:35:11 PDT 
All reviewed patches have been landed.  Closing bug.