Bug 135417 - [Linux] Resource leak of unclosed file descriptor - when open returns zero, descriptor handle leaks.
Summary: [Linux] Resource leak of unclosed file descriptor - when open returns zero, d...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-30 07:04 PDT by przemeks@pkuczynski.com
Modified: 2014-08-05 18:03 PDT (History)
4 users (show)

See Also:

Attachments
proposed patch (1.26 KB, patch)
2014-07-30 07:39 PDT, przemeks@pkuczynski.com 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description przemeks@pkuczynski.com 2014-07-30 07:04:41 PDT 
When open returns zero, fd handle leaks. Checking (fd > 0) needs to be replaced
with (fd != -1).
Comment 1 przemeks@pkuczynski.com 2014-07-30 07:39:52 PDT 
Created attachment 235744 [details]
proposed patch
Comment 2 Gyuyoung Kim 2014-07-31 01:38:58 PDT 
CC'ing Filip.
Comment 3 WebKit Commit Bot 2014-08-05 18:03:12 PDT 
Comment on attachment 235744 [details]
proposed patch

Clearing flags on attachment: 235744

Committed r172113: <http://trac.webkit.org/changeset/172113>
Comment 4 WebKit Commit Bot 2014-08-05 18:03:17 PDT 
All reviewed patches have been landed.  Closing bug.