Bug 135415 - Rename 'result' character-position pointers to 'current' in CSSParser
Summary: Rename 'result' character-position pointers to 'current' in CSSParser
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-30 02:53 PDT by Martin Hodovan
Modified: 2015-05-11 03:38 PDT (History)
2 users (show)

See Also:

Attachments
Proposed patch (19.84 KB, patch)
2014-07-30 03:00 PDT, Martin Hodovan 		ossy: review-
ossy: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Hodovan 2014-07-30 02:53:49 PDT 
Using the names 'result' and 'dest' for a pointer to the next character to be parsed
is confusing in this context. This should be replaced with the name 'current'.
Comment 1 Martin Hodovan 2014-07-30 03:00:49 PDT 
Created attachment 235739 [details]
Proposed patch
Comment 2 Darin Adler 2014-07-30 10:43:41 PDT 
Comment on attachment 235739 [details]
Proposed patch

I don’t think this is an improvement. In a function that both reads and writes, it’s confusing to have a variable named “current” that is the pointer to the next place to write. Sounds like it could be the next byte to read too. So result may be bad, but I don’t think current is better, at least in some of these functions.