Bug 135404 - [css-grid] fast/css-grid-layout/grid-element-shrink-to-fit.html fails on Retina machines
Summary: [css-grid] fast/css-grid-layout/grid-element-shrink-to-fit.html fails on Reti...
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: LayoutTestFailure
Depends on:
Blocks:
 
Reported: 2014-07-29 16:29 PDT by Alexey Proskuryakov
Modified: 2024-07-08 16:33 PDT (History)
7 users (show)

See Also:


Attachments
the diff (9.04 KB, image/png)
2014-07-29 16:30 PDT, Alexey Proskuryakov
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-07-29 16:29:14 PDT
fast/css-grid-layout/grid-element-shrink-to-fit.html always fails for me in WK2 mode on my Retina MacBook Pro.
Comment 1 Alexey Proskuryakov 2014-07-29 16:30:28 PDT
Created attachment 235715 [details]
the diff
Comment 2 Sergio Villar Senin 2014-07-30 01:31:41 PDT
I don't get why you attach that diff as this is not a pixel test. Could you provide the text differences you get?
Comment 3 Sergio Villar Senin 2014-07-30 01:43:12 PDT
(In reply to comment #2)
> I don't get why you attach that diff as this is not a pixel test. Could you provide the text differences you get?

Beh forget about it, I thought the test was a regular checkLayout() test, but that was Blink not WebKit.
Comment 4 zalan 2014-07-31 20:20:15 PDT
it looks like a subpixel alignment issue to me.
Comment 5 zalan 2014-08-01 09:08:46 PDT
This fails at an odd combination. It works fine both on retina and non-retina displays, but when forcing non-retina device scale on a retina screen, some boxes get sized incorrectly.
Comment 7 Alexey Proskuryakov 2024-07-08 16:33:21 PDT
wpt.fyi results wouldn't be doing the same thing of running in a 1x window on a 2x device. But looks like our test is actually now passing.