WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
ASSIGNED
135404
[css-grid] fast/css-grid-layout/grid-element-shrink-to-fit.html fails on Retina machines
https://bugs.webkit.org/show_bug.cgi?id=135404
Summary
[css-grid] fast/css-grid-layout/grid-element-shrink-to-fit.html fails on Reti...
Alexey Proskuryakov
Reported
2014-07-29 16:29:14 PDT
fast/css-grid-layout/grid-element-shrink-to-fit.html always fails for me in WK2 mode on my Retina MacBook Pro.
Attachments
the diff
(9.04 KB, image/png)
2014-07-29 16:30 PDT
,
Alexey Proskuryakov
no flags
Details
View All
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2014-07-29 16:30:28 PDT
Created
attachment 235715
[details]
the diff
Sergio Villar Senin
Comment 2
2014-07-30 01:31:41 PDT
I don't get why you attach that diff as this is not a pixel test. Could you provide the text differences you get?
Sergio Villar Senin
Comment 3
2014-07-30 01:43:12 PDT
(In reply to
comment #2
)
> I don't get why you attach that diff as this is not a pixel test. Could you provide the text differences you get?
Beh forget about it, I thought the test was a regular checkLayout() test, but that was Blink not WebKit.
alan
Comment 4
2014-07-31 20:20:15 PDT
it looks like a subpixel alignment issue to me.
alan
Comment 5
2014-08-01 09:08:46 PDT
This fails at an odd combination. It works fine both on retina and non-retina displays, but when forcing non-retina device scale on a retina screen, some boxes get sized incorrectly.
Ahmad Saleem
Comment 6
2024-07-08 16:28:11 PDT
This was migrated to WPT by Blink / Chromium here -
https://github.com/web-platform-tests/wpt/commit/1ab0f90bff15877f3749687d615f4ec34053e840
We can delete this local copy now. We pass WPT variant -
https://wpt.fyi/results/css/css-grid/grid-model/grid-size-shrink-to-fit-001.html?label=master&label=experimental&aligned&q=grid-size-shrink-to-fit-001.html
Alexey Proskuryakov
Comment 7
2024-07-08 16:33:21 PDT
wpt.fyi results wouldn't be doing the same thing of running in a 1x window on a 2x device. But looks like our test is actually now passing.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug