Bug 135372 – Web Inspector: Dragging selection window when mouse goes out of window bounds does not behave as expected

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
Dragging selection window when mouse goes out of window bounds does not behave as expected. The selection window moves left/right as the mouse moves left/right outside of the window. The drag should only move once the mouse comes back over the window. It should always be vertically aligned with the cursor when the cursor is over the window.

* STEPS TO REPRODUCE
1. Open inspector
2. Select a small time range
3. Start dragging the selection (from the time ruler so you move the selection entirely with the mouse)
4. Mouse out of the right side of the window (ranged selection is flush to the right side)
5. Start moving the mouse back left to the window
  => ranged selection moved left! I would only expect this once the mouse is back over the window

[Radar WebKit Bug Importer]

<rdar://problem/17836873>

[Joseph Pecoraro]

Created attachment 236217 [details]
[PATCH] Proposed Fix

[Timothy Hatcher]

Comment on attachment 236217 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=236217&action=review

> Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js:611
> +            var selectionDragElementRects = this._selectionDragElement.getBoundingClientRect();

selectionDragElementRect instead of selectionDragElementRects?

[Joseph Pecoraro]

Comment on attachment 236217 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=236217&action=review

>> Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js:611
>> +            var selectionDragElementRects = this._selectionDragElement.getBoundingClientRect();
> 
> selectionDragElementRect instead of selectionDragElementRects?

Oop, yeah. Will fix.

[Joseph Pecoraro]

<http://trac.webkit.org/changeset/172249>