Bug 135372 - Web Inspector: Dragging selection window when mouse goes out of window bounds does not behave as expected
Summary: Web Inspector: Dragging selection window when mouse goes out of window bounds...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-07-28 17:11 PDT by Joseph Pecoraro
Modified: 2014-08-07 13:51 PDT (History)
4 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (4.76 KB, patch)
2014-08-07 13:44 PDT, Joseph Pecoraro
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-07-28 17:11:50 PDT
* SUMMARY
Dragging selection window when mouse goes out of window bounds does not behave as expected. The selection window moves left/right as the mouse moves left/right outside of the window. The drag should only move once the mouse comes back over the window. It should always be vertically aligned with the cursor when the cursor is over the window.

* STEPS TO REPRODUCE
1. Open inspector
2. Select a small time range
3. Start dragging the selection (from the time ruler so you move the selection entirely with the mouse)
4. Mouse out of the right side of the window (ranged selection is flush to the right side)
5. Start moving the mouse back left to the window
  => ranged selection moved left! I would only expect this once the mouse is back over the window
Comment 1 Radar WebKit Bug Importer 2014-07-28 17:12:41 PDT
<rdar://problem/17836873>
Comment 2 Joseph Pecoraro 2014-08-07 13:44:33 PDT
Created attachment 236217 [details]
[PATCH] Proposed Fix
Comment 3 Timothy Hatcher 2014-08-07 13:46:31 PDT
Comment on attachment 236217 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=236217&action=review

> Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js:611
> +            var selectionDragElementRects = this._selectionDragElement.getBoundingClientRect();

selectionDragElementRect instead of selectionDragElementRects?
Comment 4 Joseph Pecoraro 2014-08-07 13:47:09 PDT
Comment on attachment 236217 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=236217&action=review

>> Source/WebInspectorUI/UserInterface/Views/TimelineRuler.js:611
>> +            var selectionDragElementRects = this._selectionDragElement.getBoundingClientRect();
> 
> selectionDragElementRect instead of selectionDragElementRects?

Oop, yeah. Will fix.
Comment 5 Joseph Pecoraro 2014-08-07 13:51:54 PDT
<http://trac.webkit.org/changeset/172249>