Bug 135360 - Web Inspector: Unexpected dark border on selected but window inactive timeline
Summary: Web Inspector: Unexpected dark border on selected but window inactive timeline
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-07-28 15:39 PDT by Joseph Pecoraro
Modified: 2014-07-28 17:58 PDT (History)
6 users (show)

See Also:

Attachments
[IMAGE] Issue (13.75 KB, image/png)
2014-07-28 15:51 PDT, Joseph Pecoraro 		no flags Details
Patch (2.37 KB, patch)
2014-07-28 16:57 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
Patch (2.52 KB, patch)
2014-07-28 17:20 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-07-28 15:39:17 PDT 
* SUMMARY
Unexpected dark border on selected but window inactive timeline.

* STEPS TO REPRODUCE
1. Inspect apple.com
2. Click Timelines
3. Click Layout & Rendering
4. Click desktop to blur the window
  => unexpected dark border under "Layout & Rendering"
Comment 1 Radar WebKit Bug Importer 2014-07-28 15:40:44 PDT 
<rdar://problem/17835401>
Comment 2 Joseph Pecoraro 2014-07-28 15:51:36 PDT 
Created attachment 235624 [details]
[IMAGE] Issue

Image of the issue.
Comment 3 Timothy Hatcher 2014-07-28 16:47:57 PDT 
I have a fix.
Comment 4 Timothy Hatcher 2014-07-28 16:57:33 PDT 
Created attachment 235643 [details]
Patch
Comment 5 Joseph Pecoraro 2014-07-28 17:05:05 PDT 
Comment on attachment 235643 [details]
Patch

This still looks a little weird to me.

Compare when Network is selected and the window is inactive to when Layout & Rendering is selected and the window is inactive. In the Layout & Rendering case, the selected row has no top border but a bottom border. Could be expected, but still looks a little uneven.

Leaving cq to you.
Comment 6 Timothy Hatcher 2014-07-28 17:20:51 PDT 
Created attachment 235650 [details]
Patch
Comment 7 Joseph Pecoraro 2014-07-28 17:24:55 PDT 
Comment on attachment 235650 [details]
Patch

r=me

Much nicer! Thanks
Comment 8 WebKit Commit Bot 2014-07-28 17:58:34 PDT 
Comment on attachment 235650 [details]
Patch

Clearing flags on attachment: 235650

Committed r171716: <http://trac.webkit.org/changeset/171716>
Comment 9 WebKit Commit Bot 2014-07-28 17:58:36 PDT 
All reviewed patches have been landed.  Closing bug.