Text-shadow with (0, 0) offset and radius = 0 is ugly
Created attachment 235620 [details] Patch
<rdar://problem/15000806>
Comment on attachment 235620 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235620&action=review > Source/WebCore/rendering/TextPainter.cpp:68 > + const auto& shadow = *shadowPtr; > + return shadow.location() == IntPoint() && !shadow.radius(); Seems a little strange to have this local variable just so we can use "." in two places instead of "->". > Source/WebCore/rendering/TextPainter.cpp:84 > + if (shadow && !shadowIsEmpty) No need to null check shadow here since isEmptyShadow already null checks it.
http://trac.webkit.org/changeset/172153
This caused a build failure: http://build.webkit.org/builders/Apple%20Mavericks%20Debug%20%28Build%29/builds/9771/steps/compile-webkit/logs/stdio
(In reply to comment #5) > This caused a build failure: > http://build.webkit.org/builders/Apple%20Mavericks%20Debug%20%28Build%29/builds/9771/steps/compile-webkit/logs/stdio Fixed in http://trac.webkit.org/changeset/172156.
(In reply to comment #4) > http://trac.webkit.org/changeset/172153 This caused bug 136612.