Bug 135357 - Text-shadow with (0, 0) offset and radius = 0 is ugly
Summary: Text-shadow with (0, 0) offset and radius = 0 is ugly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-07-28 15:00 PDT by Myles C. Maxfield
Modified: 2014-09-07 12:47 PDT (History)
11 users (show)

See Also:


Attachments
Patch (4.42 KB, patch)
2014-07-28 15:04 PDT, Myles C. Maxfield
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2014-07-28 15:00:47 PDT
Text-shadow with (0, 0) offset and radius = 0 is ugly
Comment 1 Myles C. Maxfield 2014-07-28 15:04:10 PDT
Created attachment 235620 [details]
Patch
Comment 2 Myles C. Maxfield 2014-07-28 15:04:36 PDT
<rdar://problem/15000806>
Comment 3 Darin Adler 2014-08-05 16:58:04 PDT
Comment on attachment 235620 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235620&action=review

> Source/WebCore/rendering/TextPainter.cpp:68
> +    const auto& shadow = *shadowPtr;
> +    return shadow.location() == IntPoint() && !shadow.radius();

Seems a little strange to have this local variable just so we can use "." in two places instead of "->".

> Source/WebCore/rendering/TextPainter.cpp:84
> +        if (shadow && !shadowIsEmpty)

No need to null check shadow here since isEmptyShadow already null checks it.
Comment 4 Myles C. Maxfield 2014-08-06 10:36:39 PDT
http://trac.webkit.org/changeset/172153
Comment 7 mitz 2014-09-07 12:47:24 PDT
(In reply to comment #4)
> http://trac.webkit.org/changeset/172153

This caused bug 136612.