Bug 135357 – Text-shadow with (0, 0) offset and radius = 0 is ugly

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

Text-shadow with (0, 0) offset and radius = 0 is ugly

[Myles C. Maxfield]

Created attachment 235620 [details]
Patch

[Myles C. Maxfield]

<rdar://problem/15000806>

[Darin Adler]

Comment on attachment 235620 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235620&action=review

> Source/WebCore/rendering/TextPainter.cpp:68
> +    const auto& shadow = *shadowPtr;
> +    return shadow.location() == IntPoint() && !shadow.radius();

Seems a little strange to have this local variable just so we can use "." in two places instead of "->".

> Source/WebCore/rendering/TextPainter.cpp:84
> +        if (shadow && !shadowIsEmpty)

No need to null check shadow here since isEmptyShadow already null checks it.

[Myles C. Maxfield]

http://trac.webkit.org/changeset/172153

[Mark Lam]

This caused a build failure:
http://build.webkit.org/builders/Apple%20Mavericks%20Debug%20%28Build%29/builds/9771/steps/compile-webkit/logs/stdio

[Mark Lam]

(In reply to comment #5)
> This caused a build failure:
> http://build.webkit.org/builders/Apple%20Mavericks%20Debug%20%28Build%29/builds/9771/steps/compile-webkit/logs/stdio

Fixed in http://trac.webkit.org/changeset/172156.

(In reply to comment #4)
> http://trac.webkit.org/changeset/172153

This caused bug 136612.