Bug 135344 - REGRESSION (r160806): CSS zoom property doesn't work on anything inside anchors.
Summary: REGRESSION (r160806): CSS zoom property doesn't work on anything inside anchors.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: InRadar, Performance
Depends on:
Blocks:
 
Reported: 2014-07-28 11:43 PDT by Andreas Kling
Modified: 2014-07-28 13:45 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.83 KB, patch)
2014-07-28 11:59 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff
Patch (3.92 KB, patch)
2014-07-28 12:07 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-07-28 11:43:23 PDT
<rdar://problem/17759577>
Comment 1 Andreas Kling 2014-07-28 11:59:59 PDT
Created attachment 235603 [details]
Patch
Comment 2 WebKit Commit Bot 2014-07-28 12:01:32 PDT
Attachment 235603 [details] did not pass style-queue:


ERROR: LayoutTests/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2014-07-28 12:07:36 PDT
Created attachment 235604 [details]
Patch
Comment 4 Simon Fraser (smfr) 2014-07-28 12:18:20 PDT
Comment on attachment 235604 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235604&action=review

> Source/WebCore/rendering/style/RenderStyle.h:2087
>  {
> +    setEffectiveZoom(effectiveZoom() * f);
>      if (compareEqual(visual->m_zoom, f))
>          return false;
>      visual.access()->m_zoom = f;
> -    setEffectiveZoom(effectiveZoom() * zoom());
>      return true;

Would be nice to rename "f" to something understandable.
Comment 5 WebKit Commit Bot 2014-07-28 13:45:08 PDT
Comment on attachment 235604 [details]
Patch

Clearing flags on attachment: 235604

Committed r171692: <http://trac.webkit.org/changeset/171692>
Comment 6 WebKit Commit Bot 2014-07-28 13:45:11 PDT
All reviewed patches have been landed.  Closing bug.