Bug 135341 – Web Replay: vectors of characters should be base64-encoded

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Brian Burg]

Add this specialization separately since at least two replay features (resource loading, navigations) depend on it.

[Brian Burg]

Created attachment 235600 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 235600 [details]
Patch

Clearing flags on attachment: 235600

Committed r171682: <http://trac.webkit.org/changeset/171682>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Mark Hahnenberg]

(In reply to comment #2)
> (From update of attachment 235600 [details])
> Clearing flags on attachment: 235600
> 
> Committed r171682: <http://trac.webkit.org/changeset/171682>

Looks like this broke the build.

[Mark Hahnenberg]

(In reply to comment #4)
> (In reply to comment #2)
> > (From update of attachment 235600 [details] [details])
> > Clearing flags on attachment: 235600
> > 
> > Committed r171682: <http://trac.webkit.org/changeset/171682>
> 
> Looks like this broke the build.

See, e.g. http://build.webkit.org/builders/Apple%20Mavericks%2032-bit%20JSC%20%28BuildAndTest%29/builds/3167

[Brian Burg]

(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #2)
> > > (From update of attachment 235600 [details] [details] [details])
> > > Clearing flags on attachment: 235600
> > > 
> > > Committed r171682: <http://trac.webkit.org/changeset/171682>
> > 
> > Looks like this broke the build.
> 
> See, e.g. http://build.webkit.org/builders/Apple%20Mavericks%2032-bit%20JSC%20%28BuildAndTest%29/builds/3167

Landed a fix in <http://trac.webkit.org/changeset/171694>. Still not sure why the build break cannot reproduce locally or on EWS...

[Mark Hahnenberg]

(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > (In reply to comment #2)
> > > > (From update of attachment 235600 [details] [details] [details] [details])
> > > > Clearing flags on attachment: 235600
> > > > 
> > > > Committed r171682: <http://trac.webkit.org/changeset/171682>
> > > 
> > > Looks like this broke the build.
> > 
> > See, e.g. http://build.webkit.org/builders/Apple%20Mavericks%2032-bit%20JSC%20%28BuildAndTest%29/builds/3167
> 
> Landed a fix in <http://trac.webkit.org/changeset/171694>. Still not sure why the build break cannot reproduce locally or on EWS...

Might be 32-bit specific? *shrugs*

[Brian Burg]

Still didn't fix it. It seems this is the first use of base64encode() from a header. Looking at Base64.h, there are 4 adapters and 2 actual implementations, but all are marked WTF_EXPORT_PRIVATE. Since EncodedValue.h is included multiple places, it will trigger weak symbol problems that seem to have been latent in that header.