Bug 135310 - Parent fullscreen from window instead of view
Summary: Parent fullscreen from window instead of view
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-25 16:14 PDT by Jeremy Jones
Modified: 2014-07-25 17:48 PDT (History)
7 users (show)

See Also:


Attachments
Patch (5.70 KB, patch)
2014-07-25 16:19 PDT, Jeremy Jones
no flags Details | Formatted Diff | Diff
Patch (5.70 KB, patch)
2014-07-25 16:20 PDT, Jeremy Jones
jer.noble: review+
Details | Formatted Diff | Diff
Patch for landing. (6.04 KB, patch)
2014-07-25 16:42 PDT, Jeremy Jones
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2014-07-25 16:14:26 PDT
'parent fullscren from window instead of view
Comment 1 Jeremy Jones 2014-07-25 16:19:05 PDT
Created attachment 235550 [details]
Patch
Comment 2 Jeremy Jones 2014-07-25 16:20:24 PDT
Created attachment 235551 [details]
Patch
Comment 3 Jeremy Jones 2014-07-25 16:23:44 PDT
<rdar://problem/17782407>
Comment 4 Jer Noble 2014-07-25 16:36:59 PDT
Comment on attachment 235551 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235551&action=review

> Source/WebKit/mac/ChangeLog:7
> +        Reviewed by NOBODY (OOPS!).
> +

This and...

> Source/WebKit2/ChangeLog:7
> +        Reviewed by NOBODY (OOPS!).
> +

...this could use an explanation about why switching from view-parented to window-parented fixes the rotation problem.

Other than that, looks good.
Comment 5 Jeremy Jones 2014-07-25 16:42:41 PDT
Created attachment 235553 [details]
Patch for landing.
Comment 6 Jeremy Jones 2014-07-25 16:47:22 PDT
This also needs a WK2 reviewer.
Comment 7 WebKit Commit Bot 2014-07-25 17:43:37 PDT
Comment on attachment 235553 [details]
Patch for landing.

Clearing flags on attachment: 235553

Committed r171635: <http://trac.webkit.org/changeset/171635>