Bug 135304 – [iOS] REGRESSION(r171526): Images fail to load sometimes in Apple Store app

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Pratik Solanki]

[iOS] REGRESSION(r171526): Images fail to load sometimes

[Pratik Solanki]

Created attachment 235545 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 235545 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235545&action=review

> Source/WebCore/ChangeLog:15
> +        No new tests because no functional changes.

This doesn't seem like an accurate description - the fix is supposed to make it so that images always load.

[Pratik Solanki]

Committed r171619: <http://trac.webkit.org/changeset/171619>

[Darin Adler]

Check-in comment says this is “covered by existing tests”, but clearly that’s wrong. Was there a test failing when this was broken?

[Pratik Solanki]

(In reply to comment #4)
> Check-in comment says this is “covered by existing tests”, but clearly that’s wrong. Was there a test failing when this was broken?

A number of layout tests in fast/images fail without this change. They only fail in WK1 since WK2 with network process does not go through this code path (if you disable network process you will likely hit this in WK2 as well). This is why I didn't see this bug during my original testing of r171526 and which is why this showed up as broken images in Apple Store app. Any image that we get in a single CFDataRef from CFNetwork will fail to load. This includes images that are disk cache file backed.

[Darin Adler]

(In reply to comment #5)
> A number of layout tests in fast/images fail without this change.

OK. Thanks. I didn’t know that.