RESOLVED INVALID135285
There are unnecessary condition check on FontGlyphs.cpp 
https://bugs.webkit.org/show_bug.cgi?id=135285
Summary There are unnecessary condition check on FontGlyphs.cpp
byeongha.cho
Reported 2014-07-25 02:13:13 PDT
There are condition check for characterFontData followed by same condition check for characterFontData in the FontGlyphs::glyphDataAndPageForCharacter(). I think this is not necessary.
Attachments
Patch (1.67 KB, patch)
2014-07-25 04:45 PDT, byeongha.cho 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
byeongha.cho
Comment 1 2014-07-25 04:45:54 PDT
Created attachment 235507 [details] Patch
Myles C. Maxfield
Comment 2 2014-07-25 08:29:48 PDT
Comment on attachment 235507 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235507&action=review > Source/WebCore/platform/graphics/FontGlyphs.cpp:389 > characterFontData = characterFontData->variantFontData(description, variant); This function might return nullptr.
Myles C. Maxfield
Comment 3 2014-07-25 08:30:02 PDT
I'm not a reviewer but I would r- this.
byeongha.cho
Comment 4 2014-07-27 07:23:23 PDT
Yes, I agree that variantFontData() could rarely return nullptr. So I close this issue.
byeongha.cho
Comment 5 2014-07-27 07:40:38 PDT
Thank you for reviewing.
Darin Adler
Comment 6 2014-07-27 23:28:49 PDT
Comment on attachment 235507 [details] Patch As Myles says, this patch is only correct if variantFontData never returns null. Did you prove that variantFontData will never return null?
Note You need to log in before you can comment on or make changes to this bug.