Bug 135281 - Crashes under scanSelectionForTelephoneNumbers in Range::text() on some sites
Summary: Crashes under scanSelectionForTelephoneNumbers in Range::text() on some sites
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-07-24 19:58 PDT by Tim Horton
Modified: 2014-07-24 20:13 PDT (History)
3 users (show)

See Also:


Attachments
patch (1.48 KB, patch)
2014-07-24 20:01 PDT, Tim Horton
rniwa: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Tim Horton 2014-07-24 20:01:48 PDT
Created attachment 235493 [details]
patch
Comment 2 Ryosuke Niwa 2014-07-24 20:03:59 PDT
Comment on attachment 235493 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235493&action=review

> Source/WebCore/editing/Editor.cpp:3396
>      RefPtr<Range> extendedRange = extendedSelection.toNormalizedRange();
>  
> +    if (!extendedRange) {

Looks like we can move extendedRange into the if expression and then wrap the following ~8 lines of code inside the if statement instead.
That way, we make exactly one call to selectedTelephoneNumberRangesChanged.
Comment 3 Tim Horton 2014-07-24 20:11:43 PDT
Comment on attachment 235493 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235493&action=review

>> Source/WebCore/editing/Editor.cpp:3396
>> +    if (!extendedRange) {
> 
> Looks like we can move extendedRange into the if expression and then wrap the following ~8 lines of code inside the if statement instead.
> That way, we make exactly one call to selectedTelephoneNumberRangesChanged.

I'm teetering back and forth between the two options, because I prefer the early return but at the same time having two calls to selectedTelephoneNumberRangesChanged is kind of annoying. That said, there's another early return that calls selectedTelephoneNumberRangesChanged above, and I would never make this change to that one, so I think I'm going to keep it consistent. Thanks for your help and review!
Comment 4 Tim Horton 2014-07-24 20:13:00 PDT
http://trac.webkit.org/changeset/171577