Bug 135281 – Crashes under scanSelectionForTelephoneNumbers in Range::text() on some sites

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Tim Horton]

Steps to Reproduce:

1. Load http://dict.leo.org/#/search=apple&searchLoc=0&resultOrder=basic&multiwordShowSingle=on

<rdar://problem/17803347>

[Tim Horton]

Created attachment 235493 [details]
patch

[Ryosuke Niwa]

Comment on attachment 235493 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235493&action=review

> Source/WebCore/editing/Editor.cpp:3396
>      RefPtr<Range> extendedRange = extendedSelection.toNormalizedRange();
>  
> +    if (!extendedRange) {

Looks like we can move extendedRange into the if expression and then wrap the following ~8 lines of code inside the if statement instead.
That way, we make exactly one call to selectedTelephoneNumberRangesChanged.

[Tim Horton]

Comment on attachment 235493 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235493&action=review

>> Source/WebCore/editing/Editor.cpp:3396
>> +    if (!extendedRange) {
> 
> Looks like we can move extendedRange into the if expression and then wrap the following ~8 lines of code inside the if statement instead.
> That way, we make exactly one call to selectedTelephoneNumberRangesChanged.

I'm teetering back and forth between the two options, because I prefer the early return but at the same time having two calls to selectedTelephoneNumberRangesChanged is kind of annoying. That said, there's another early return that calls selectedTelephoneNumberRangesChanged above, and I would never make this change to that one, so I think I'm going to keep it consistent. Thanks for your help and review!

[Tim Horton]

http://trac.webkit.org/changeset/171577