Bug 135273 - [iOS] REGRESSION (WebKit2): Can't login to Wordpress.com, facebook.com when always allowing cookies
Summary: [iOS] REGRESSION (WebKit2): Can't login to Wordpress.com, facebook.com when a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-07-24 17:07 PDT by Daniel Bates
Modified: 2014-07-24 17:15 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.58 KB, patch)
2014-07-24 17:10 PDT, Daniel Bates 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2014-07-24 17:07:42 PDT 
When allowing all cookies, some sites may not behave correctly, including Facebook.com.
Comment 1 Daniel Bates 2014-07-24 17:07:57 PDT 
<rdar://problem/17598815>
Comment 2 Daniel Bates 2014-07-24 17:10:26 PDT 
Created attachment 235475 [details]
Patch
Comment 3 Alexey Proskuryakov 2014-07-24 17:12:45 PDT 
Comment on attachment 235475 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235475&action=review

> Source/WebCore/ChangeLog:5
> +        https://bugs.webkit.org/show_bug.cgi?id=135273

Please add a Radar link here too.

> Source/WebCore/ChangeLog:11
> +        Currently, when we update the CRURLRequest object associated with a ResourceRequest object

Typo: should be CFURLRequest.
Comment 4 Daniel Bates 2014-07-24 17:13:33 PDT 
Comment on attachment 235475 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235475&action=review

>> Source/WebCore/ChangeLog:5
>> +        https://bugs.webkit.org/show_bug.cgi?id=135273
> 
> Please add a Radar link here too.

Will do before landing.

>> Source/WebCore/ChangeLog:11
>> +        Currently, when we update the CRURLRequest object associated with a ResourceRequest object
> 
> Typo: should be CFURLRequest.

Will substitute CFURLRequest for CRURLRequest before landing.
Comment 5 Daniel Bates 2014-07-24 17:15:40 PDT 
Committed r171559: <http://trac.webkit.org/changeset/171559>