Bug 135237 - [TexMap] GraphicsLayerTextureMapper::addAnimation() box size parameter should be FloatSize
Summary: [TexMap] GraphicsLayerTextureMapper::addAnimation() box size parameter should...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-24 05:38 PDT by Zan Dobersek
Modified: 2014-07-29 01:13 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.65 KB, patch)
2014-07-24 05:43 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2014-07-24 05:38:34 PDT 
[TexMap] GraphicsLayerTextureMapper::addAnimation() box size parameter should be FloatSize
Comment 1 Zan Dobersek 2014-07-24 05:43:13 PDT 
Created attachment 235426 [details]
Patch
Comment 2 Martin Robinson 2014-07-24 07:20:00 PDT 
Comment on attachment 235426 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235426&action=review

> Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.h:84
> -    virtual bool addAnimation(const KeyframeValueList&, const IntSize&, const Animation*, const String&, double);
> +    virtual bool addAnimation(const KeyframeValueList&, const FloatSize&, const Animation*, const String&, double);

I think adding override to this delcaration is a good idea, since it has the potential to catch these errors in the future.
Comment 3 Zan Dobersek 2014-07-29 01:10:06 PDT 
Comment on attachment 235426 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235426&action=review

>> Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.h:84
>> +    virtual bool addAnimation(const KeyframeValueList&, const FloatSize&, const Animation*, const String&, double);
> 
> I think adding override to this delcaration is a good idea, since it has the potential to catch these errors in the future.

That should be done throughout the texmap code. I'll at least run clang-modernize over it, but there are also other things I want to improve.
Comment 4 Zan Dobersek 2014-07-29 01:13:31 PDT 
Comment on attachment 235426 [details]
Patch

Clearing flags on attachment: 235426

Committed r171725: <http://trac.webkit.org/changeset/171725>
Comment 5 Zan Dobersek 2014-07-29 01:13:40 PDT 
All reviewed patches have been landed.  Closing bug.