Bug 135233 – Member name collision in RenderView and SelectionSubtreeRoot

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Radu Stavila]

SelectionSubtreeRoot members:

    RenderObject* m_selectionStart;
    int m_selectionStartPos;
    RenderObject* m_selectionEnd;
    int m_selectionEndPos;


RenderView members:

    RenderObject* m_selectionStart;
    RenderObject* m_selectionEnd;
    int m_selectionStartPos;
    int m_selectionEndPos;


Because RenderView inherits SelectionSubtreeRoot, this presents a problem. Furthermore, the getter/setter methods also have identical names (selectionStart(), setSelectionStart(...) etc). 

Example: in RenderView.cpp, setting the start/end selection members to some values. Then calling selectionStartEndPositions(...) which retrieves those values. Because this method is inside SelectionSubtreeRoot, it will return the version of the selection members from SelectionSubtreeRoot, not the ones you would normally expect it to. This has great potential for creating confusion and hard-to-track issues.

[Radu Stavila]

Created attachment 235420 [details]
Patch for renaming selection members - NOT FOR LANDING

The attached patch renames the members inside RenderView but causes fast/dom/HTMLObjectElement/beforeload-set-text-crash.xhtml to crash.

[Radu Stavila]

Update: the crash was not caused by the rename. After the initial patch lands (https://bugs.webkit.org/show_bug.cgi?id=134303) I will try to re-land this.

[Radu Stavila]

Created attachment 235740 [details]
Patch

[Mihnea Ovidenie]

Comment on attachment 235740 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235740&action=review

> Source/WebCore/rendering/RenderView.h:92
> +    RenderObject* selectionUnsplitStart() const { return m_unsplitSelectionStart; }

Any reason why the function is named selectionUnsplitStart and the member is m_unsplitSelectionStart?

[Radu Stavila]

Created attachment 235743 [details]
Patch integrating reviewer feedback

[Mihnea Ovidenie]

Comment on attachment 235743 [details]
Patch integrating reviewer feedback

r=me

[WebKit Commit Bot]

Comment on attachment 235743 [details]
Patch integrating reviewer feedback

Clearing flags on attachment: 235743

Committed r171797: <http://trac.webkit.org/changeset/171797>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.