Bug 135221 – [iOS WK2] Header bar on nytimes articles lands in the wrong place after rubberbanding

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Header bar on nytimes articles lands in the wrong place after rubberbanding

[Simon Fraser (smfr)]

Created attachment 235392 [details]
Patch

[Simon Fraser (smfr)]

<rdar://problem/17542454>

[Simon Fraser (smfr)]

https://trac.webkit.org/r171498

[Benjamin Poulain]

Comment on attachment 235392 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235392&action=review

> Source/WebKit2/UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:219
> +#if PLATFORM(IOS)
> +    m_webPageProxy->didCommitLayerTree(layerTreeTransaction);
> +#endif
> +

Uh, isn't that gonna bring all the scrolling bugs back? I think that's where the code was.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 135223

[Build Bot]

Comment on attachment 235392 [details]
Patch

Attachment 235392 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6390063927656448

New failing tests:
media/track/add-and-remove-track.html

[Build Bot]

Created attachment 235398 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Simon Fraser (smfr)]

Created attachment 235473 [details]
Patch

[Benjamin Poulain]

Comment on attachment 235473 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235473&action=review

> Source/WebKit2/UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp:181
> +    if (scrolledNodeID == rootScrollingNodeID() && m_requestedScrollInfo) {
> +        m_requestedScrollInfo->requestsScrollPositionUpdate = true;
> +        m_requestedScrollInfo->requestIsProgrammaticScroll = representsProgrammaticScroll;
> +        m_requestedScrollInfo->requestedScrollPosition = scrollPosition;
> +    }

ouch, that's not pretty.

[Simon Fraser (smfr)]

https://trac.webkit.org/r171560