The Curl api offers the possibility to write log messages to file. It would be nice to enable this for debugging purposes.
Created attachment 235360 [details] Patch
Comment on attachment 235360 [details] Patch Attachment 235360 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5118260223672320 New failing tests: media/track/add-and-remove-track.html
Created attachment 235365 [details] Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 235360 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235360&action=review Otherwise this looks good > Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:237 > + , m_logFile(0) This should be nullptr.
Is there any reason why we would want there to be no log for a debug build? Does it slow it down too much? I think falling back to writing a log to the current working directory would make the logs easier to find
Created attachment 235439 [details] Patch
Comment on attachment 235439 [details] Patch r=me
(In reply to comment #7) > (From update of attachment 235439 [details]) > r=me Thanks for reviewing :)
(In reply to comment #5) > Is there any reason why we would want there to be no log for a debug build? Does it slow it down too much? I think falling back to writing a log to the current working directory would make the logs easier to find The logging is pretty verbose. I believe it will slow things down, so this patch only enables it for debug builds.
Comment on attachment 235439 [details] Patch Clearing flags on attachment: 235439 Committed r171513: <http://trac.webkit.org/changeset/171513>
All reviewed patches have been landed. Closing bug.