I fixed a bug with window-inactive yesterday, so why not compile it, too?
Created attachment 235353 [details] Patch
I was on a roll and compiled the fullscreen pseudo classes, too.
Created attachment 235355 [details] Patch
Created attachment 235356 [details] Patch
Created attachment 235358 [details] Patch
https://i.imgflip.com/ajjz5.jpg
Comment on attachment 235358 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235358&action=review Awesome! r- because I have serious doubt about PseudoClassAnyLink, the patch looks good otherwise. > Source/WebCore/css/SelectorChecker.cpp:484 > + } else if (selector->pseudoClassType() == CSSSelector::PseudoClassWindowInactive) > + return isWindowInactive(element); Can't you juste remove this code? This is handled properly by the switch() below. > Source/WebCore/cssjit/SelectorCompiler.cpp:409 > + return FunctionType::SimpleSelectorChecker; Indentation issue here. > Source/WebCore/cssjit/SelectorCompiler.cpp:415 > + return FunctionType::SimpleSelectorChecker; ditto. > Source/WebCore/cssjit/SelectorCompiler.cpp:-417 > - fragment.pseudoClasses.add(CSSSelector::PseudoClassLink); > - return FunctionType::SimpleSelectorChecker; > - This does not look right. There is no handler for PseudoClassAnyLink, it is aliased with the handler of PseudoClassLink. > Source/WebCore/cssjit/SelectorCompiler.cpp:573 > + return FunctionType::CannotCompile; I think CannotMatchAnything would make sense.
Created attachment 235361 [details] Patch
Comment on attachment 235361 [details] Patch Attachment 235361 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6743218150440960 New failing tests: media/track/add-and-remove-track.html
Created attachment 235366 [details] Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
test failure probably not from this change. https://trac.webkit.org/r171486