Allow media engines to control HTMLMediaElement's looping
Created attachment 235342 [details] WIP
Comment on attachment 235342 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=235342&action=review > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:661 > + [m_avPlayer setActionAtItemEnd:(player()->isLooping() ? AVPlayerActionAtItemEndAdvance : AVPlayerActionAtItemEndNone)]; Is it possible for player()->isLooping() and the looping parameter to be different?
Comment on attachment 235342 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=235342&action=review >> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:661 >> + [m_avPlayer setActionAtItemEnd:(player()->isLooping() ? AVPlayerActionAtItemEndAdvance : AVPlayerActionAtItemEndNone)]; > > Is it possible for player()->isLooping() and the looping parameter to be different? player()->isLooping() queries the HTMLMediaElement directly, so it's not possible for that and the "loop" attribute to be different, if that's what you're asking.
Created attachment 235359 [details] WIP Rebased
Created attachment 235394 [details] WIP Fixed Mac, GTK, and EFL build errors.
Comment on attachment 235394 [details] WIP Attachment 235394 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6490531802644480 New failing tests: media/track/track-cues-missed.html media/video-loop.html compositing/video-page-visibility.html media/track/track-cues-sorted-before-dispatch.html media/video-played-collapse.html
Created attachment 235405 [details] Archive of layout-test-results from webkit-ews-06 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Comment on attachment 235394 [details] WIP Attachment 235394 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4669225150971904 New failing tests: media/track/track-cues-missed.html media/video-loop.html compositing/video-page-visibility.html media/track/track-cues-sorted-before-dispatch.html media/video-played-collapse.html
Created attachment 235407 [details] Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5
(In reply to comment #3) > (From update of attachment 235342 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=235342&action=review > > >> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:661 > >> + [m_avPlayer setActionAtItemEnd:(player()->isLooping() ? AVPlayerActionAtItemEndAdvance : AVPlayerActionAtItemEndNone)]; > > > > Is it possible for player()->isLooping() and the looping parameter to be different? > > player()->isLooping() queries the HTMLMediaElement directly, so it's not possible for that and the "loop" attribute to be different, if that's what you're asking. I meant, is it possible for player()->isLooping() and the "loop" parameter passed to this method to be different? IOW, do you need to use player()->isLooping() or can you use the "loop" parameter as you do in the rest of this method?
Comment on attachment 235342 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=235342&action=review >>>> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:661 >>>> + [m_avPlayer setActionAtItemEnd:(player()->isLooping() ? AVPlayerActionAtItemEndAdvance : AVPlayerActionAtItemEndNone)]; >>> >>> Is it possible for player()->isLooping() and the looping parameter to be different? >> >> player()->isLooping() queries the HTMLMediaElement directly, so it's not possible for that and the "loop" attribute to be different, if that's what you're asking. > > I meant, is it possible for player()->isLooping() and the "loop" parameter passed to this method to be different? IOW, do you need to use player()->isLooping() or can you use the "loop" parameter as you do in the rest of this method? Ah, I see! Yes, there's no reason not to use "looping" here.
Comment on attachment 235394 [details] WIP This patch has been through mac-wk2 EWS over a thousand times now, each time flakily failing in a way that didn't let EWS decide what exactly regressed. Marking r- to stop wasting bot time.
Created attachment 238408 [details] Patch
Created attachment 238409 [details] Patch
Comment on attachment 238409 [details] Patch Attachment 238409 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5497006210416640 New failing tests: media/track/track-cues-missed.html media/track/track-cues-sorted-before-dispatch.html
Created attachment 238410 [details] Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 238409 [details] Patch Attachment 238409 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4946120820129792 New failing tests: media/track/track-cues-missed.html media/video-loop.html media/track/track-cues-sorted-before-dispatch.html
Created attachment 238411 [details] Archive of layout-test-results from webkit-ews-06 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Created attachment 238413 [details] WIP
Comment on attachment 238413 [details] WIP Attachment 238413 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5257817334218752 New failing tests: media/video-loop.html
Created attachment 238417 [details] Archive of layout-test-results from webkit-ews-05 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-05 Port: mac-mountainlion Platform: Mac OS X 10.8.5