NEW135188
Allow media engines to control HTMLMediaElement's looping
https://bugs.webkit.org/show_bug.cgi?id=135188
Summary Allow media engines to control HTMLMediaElement's looping
Jer Noble
Reported 2014-07-22 22:12:10 PDT
Allow media engines to control HTMLMediaElement's looping
Attachments
WIP (41.07 KB, patch)
2014-07-22 22:14 PDT, Jer Noble
no flags
WIP (43.32 KB, patch)
2014-07-23 10:53 PDT, Jer Noble
no flags
WIP (43.52 KB, patch)
2014-07-23 17:26 PDT, Jer Noble
no flags
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (732.17 KB, application/zip)
2014-07-23 22:02 PDT, Build Bot
no flags
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (765.51 KB, application/zip)
2014-07-23 23:03 PDT, Build Bot
no flags
Patch (49.24 KB, patch)
2014-09-19 22:36 PDT, Jer Noble
no flags
Patch (50.69 KB, patch)
2014-09-19 23:58 PDT, Jer Noble
no flags
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 (493.62 KB, application/zip)
2014-09-20 01:10 PDT, Build Bot
no flags
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (545.96 KB, application/zip)
2014-09-20 01:27 PDT, Build Bot
no flags
WIP (50.85 KB, patch)
2014-09-20 11:23 PDT, Jer Noble
buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion (508.83 KB, application/zip)
2014-09-20 13:09 PDT, Build Bot
no flags
Jer Noble
Comment 1 2014-07-22 22:14:09 PDT
Eric Carlson
Comment 2 2014-07-23 07:08:58 PDT
Comment on attachment 235342 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=235342&action=review > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:661 > + [m_avPlayer setActionAtItemEnd:(player()->isLooping() ? AVPlayerActionAtItemEndAdvance : AVPlayerActionAtItemEndNone)]; Is it possible for player()->isLooping() and the looping parameter to be different?
Jer Noble
Comment 3 2014-07-23 08:46:23 PDT
Comment on attachment 235342 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=235342&action=review >> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:661 >> + [m_avPlayer setActionAtItemEnd:(player()->isLooping() ? AVPlayerActionAtItemEndAdvance : AVPlayerActionAtItemEndNone)]; > > Is it possible for player()->isLooping() and the looping parameter to be different? player()->isLooping() queries the HTMLMediaElement directly, so it's not possible for that and the "loop" attribute to be different, if that's what you're asking.
Jer Noble
Comment 4 2014-07-23 10:53:58 PDT
Created attachment 235359 [details] WIP Rebased
Jer Noble
Comment 5 2014-07-23 17:26:45 PDT
Created attachment 235394 [details] WIP Fixed Mac, GTK, and EFL build errors.
Build Bot
Comment 6 2014-07-23 22:02:11 PDT
Comment on attachment 235394 [details] WIP Attachment 235394 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6490531802644480 New failing tests: media/track/track-cues-missed.html media/video-loop.html compositing/video-page-visibility.html media/track/track-cues-sorted-before-dispatch.html media/video-played-collapse.html
Build Bot
Comment 7 2014-07-23 22:02:13 PDT
Created attachment 235405 [details] Archive of layout-test-results from webkit-ews-06 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Build Bot
Comment 8 2014-07-23 23:03:30 PDT
Comment on attachment 235394 [details] WIP Attachment 235394 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4669225150971904 New failing tests: media/track/track-cues-missed.html media/video-loop.html compositing/video-page-visibility.html media/track/track-cues-sorted-before-dispatch.html media/video-played-collapse.html
Build Bot
Comment 9 2014-07-23 23:03:33 PDT
Created attachment 235407 [details] Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Eric Carlson
Comment 10 2014-07-24 05:28:21 PDT
(In reply to comment #3) > (From update of attachment 235342 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=235342&action=review > > >> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:661 > >> + [m_avPlayer setActionAtItemEnd:(player()->isLooping() ? AVPlayerActionAtItemEndAdvance : AVPlayerActionAtItemEndNone)]; > > > > Is it possible for player()->isLooping() and the looping parameter to be different? > > player()->isLooping() queries the HTMLMediaElement directly, so it's not possible for that and the "loop" attribute to be different, if that's what you're asking. I meant, is it possible for player()->isLooping() and the "loop" parameter passed to this method to be different? IOW, do you need to use player()->isLooping() or can you use the "loop" parameter as you do in the rest of this method?
Jer Noble
Comment 11 2014-07-24 08:23:09 PDT
Comment on attachment 235342 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=235342&action=review >>>> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:661 >>>> + [m_avPlayer setActionAtItemEnd:(player()->isLooping() ? AVPlayerActionAtItemEndAdvance : AVPlayerActionAtItemEndNone)]; >>> >>> Is it possible for player()->isLooping() and the looping parameter to be different? >> >> player()->isLooping() queries the HTMLMediaElement directly, so it's not possible for that and the "loop" attribute to be different, if that's what you're asking. > > I meant, is it possible for player()->isLooping() and the "loop" parameter passed to this method to be different? IOW, do you need to use player()->isLooping() or can you use the "loop" parameter as you do in the rest of this method? Ah, I see! Yes, there's no reason not to use "looping" here.
Alexey Proskuryakov
Comment 12 2014-08-14 11:53:19 PDT
Comment on attachment 235394 [details] WIP This patch has been through mac-wk2 EWS over a thousand times now, each time flakily failing in a way that didn't let EWS decide what exactly regressed. Marking r- to stop wasting bot time.
Jer Noble
Comment 13 2014-09-19 22:36:12 PDT
Jer Noble
Comment 14 2014-09-19 23:58:08 PDT
Build Bot
Comment 15 2014-09-20 01:10:05 PDT
Comment on attachment 238409 [details] Patch Attachment 238409 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5497006210416640 New failing tests: media/track/track-cues-missed.html media/track/track-cues-sorted-before-dispatch.html
Build Bot
Comment 16 2014-09-20 01:10:09 PDT
Created attachment 238410 [details] Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Build Bot
Comment 17 2014-09-20 01:27:56 PDT
Comment on attachment 238409 [details] Patch Attachment 238409 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4946120820129792 New failing tests: media/track/track-cues-missed.html media/video-loop.html media/track/track-cues-sorted-before-dispatch.html
Build Bot
Comment 18 2014-09-20 01:27:59 PDT
Created attachment 238411 [details] Archive of layout-test-results from webkit-ews-06 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Jer Noble
Comment 19 2014-09-20 11:23:30 PDT
Build Bot
Comment 20 2014-09-20 13:09:16 PDT
Comment on attachment 238413 [details] WIP Attachment 238413 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5257817334218752 New failing tests: media/video-loop.html
Build Bot
Comment 21 2014-09-20 13:09:19 PDT
Created attachment 238417 [details] Archive of layout-test-results from webkit-ews-05 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-05 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Note You need to log in before you can comment on or make changes to this bug.