Bug 135185 - Migrate accessibility/ to using nullptr instead of 0
Summary: Migrate accessibility/ to using nullptr instead of 0
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
Depends on:
Reported: 2014-07-22 19:08 PDT by Myles C. Maxfield
Modified: 2014-07-23 07:57 PDT (History)
13 users (show)

See Also:

Patch (97.26 KB, patch)
2014-07-22 19:09 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2014-07-22 19:08:29 PDT
Migrate accessibility/ to using nullptr instead of 0
Comment 1 Myles C. Maxfield 2014-07-22 19:09:26 PDT
Created attachment 235337 [details]
Comment 2 WebKit Commit Bot 2014-07-22 19:11:58 PDT
Attachment 235337 [details] did not pass style-queue:

ERROR: Source/WebCore/accessibility/win/AccessibilityObjectWrapperWin.h:52:  Should be indented on a separate line, with the colon or comma first on that line.  [whitespace/indent] [4]
ERROR: Source/WebCore/accessibility/AccessibilityObject.cpp:2214:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 2 in 30 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Myles C. Maxfield 2014-07-22 19:16:48 PDT
The style comments are false negatives.
Comment 4 Simon Fraser (smfr) 2014-07-22 22:34:35 PDT
Comment on attachment 235337 [details]

Comment 5 WebKit Commit Bot 2014-07-23 07:57:35 PDT
Comment on attachment 235337 [details]

Clearing flags on attachment: 235337

Committed r171477: <http://trac.webkit.org/changeset/171477>
Comment 6 WebKit Commit Bot 2014-07-23 07:57:39 PDT
All reviewed patches have been landed.  Closing bug.