Bug 135181 - Ensure we compute the min and max height of replaced elements to 'none' or 0 when appropriate.
Summary: Ensure we compute the min and max height of replaced elements to 'none' or 0 ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bem Jones-Bey
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-07-22 15:43 PDT by Bem Jones-Bey
Modified: 2023-07-03 06:42 PDT (History)
8 users (show)

See Also:

Attachments
Patch (12.76 KB, patch)
2014-07-22 16:03 PDT, Bem Jones-Bey 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bem Jones-Bey 2014-07-22 15:43:46 PDT 
Ensure we compute the min and max height of replaced elements to 'none' or 0 when appropriate.
Comment 1 Bem Jones-Bey 2014-07-22 16:03:17 PDT 
Created attachment 235323 [details]
Patch
Comment 2 Dave Hyatt 2014-07-23 10:33:53 PDT 
Comment on attachment 235323 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2014-07-23 10:56:43 PDT 
Comment on attachment 235323 [details]
Patch

Clearing flags on attachment: 235323

Committed r171480: <http://trac.webkit.org/changeset/171480>
Comment 4 WebKit Commit Bot 2014-07-23 10:56:45 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Dave Hyatt 2014-07-25 12:02:08 PDT 
This needs to be rolled out. It's broken replaced elements in books/columns.
Comment 6 Dave Hyatt 2014-07-25 12:12:13 PDT 
So iBooks relies on being able to use max-width/height to clamp image sizes. This change has broken that completely, leaving the images to spill across columns/pages. 

We'll need to figure something out for iBooks before landing this again. It might be that viewport units are what they should switch to instead of 100%, but what really surprised me is that even in quirks mode, the pagination stuff stayed broken.
Comment 7 Dave Hyatt 2014-07-25 12:40:48 PDT 
See

https://bugs.webkit.org/show_bug.cgi?id=135204

for a test case that shows what books do.
Comment 8 Ahmad Saleem 2023-07-02 16:17:07 PDT 
Looking at this code: https://searchfox.org/wubkat/source/Source/WebCore/rendering/RenderBox.cpp#3588

Git Blame seems to suggest this commit:

https://commits.webkit.org/189967@main

Do we need to keep it open? @Alan?
Comment 9 Radar WebKit Bug Importer 2023-07-03 06:42:17 PDT 
<rdar://problem/111684345>