Bug 135180 - REGRESSION (WebKit2): Selection inside accelerated overflow:scroll doesn't track scrolling
Summary: REGRESSION (WebKit2): Selection inside accelerated overflow:scroll doesn't tr...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Enrica Casucci
Keywords: InRadar
Depends on:
Reported: 2014-07-22 15:15 PDT by Enrica Casucci
Modified: 2014-07-23 09:00 PDT (History)
8 users (show)

See Also:

Patch (21.66 KB, patch)
2014-07-22 15:45 PDT, Enrica Casucci
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Enrica Casucci 2014-07-22 15:15:41 PDT
Create a selection inside an accelerated overflow.
Scroll inside the area.
The selection stays at the original position.

Comment 1 Enrica Casucci 2014-07-22 15:45:33 PDT
Created attachment 235320 [details]
Comment 2 Simon Fraser (smfr) 2014-07-22 16:00:56 PDT
Comment on attachment 235320 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=235320&action=review

> Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp:315
> +        if (scrollingLayerPositionAction == SetScrollingLayerPosition)
> +            m_page->editorClient()->updateSelection();
> +#endif

Can we push this #ifdef down into editorClient, giving EditorClient an overflowScrollPositionnChanged(bool) which is not #ifdeffed, and only implementing for iOS?

This would be better than having #if PLATFORM(IOS) in core code.
Comment 3 Enrica Casucci 2014-07-22 16:29:09 PDT
Committed revision 171370.
Comment 4 Brent Fulgham 2014-07-23 09:00:08 PDT
This introduced a build failure on Windows due to a missing implementation of 'overflowScrollPositionChanged'.

Build fix landed: <http://trac.webkit.org/changeset/171403>