Bug 135179 – Array.concat() should work on runtime arrays too

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Lam]

Patch coming.

[Mark Lam]

<rdar://problem/17544620>

[Mark Lam]

Created attachment 235319 [details]
the patch.

[WebKit Commit Bot]

Attachment 235319 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/jsc.cpp:288:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/jsc.cpp:289:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/jsc.cpp:290:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/JavaScriptCore/jsc.cpp:301:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/jsc.cpp:361:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/jsc.cpp:361:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/JavaScriptCore/jsc.cpp:362:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/jsc.cpp:363:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/jsc.cpp:365:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/jsc.cpp:366:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/jsc.cpp:367:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/jsc.cpp:373:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/jsc.cpp:373:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/JavaScriptCore/jsc.cpp:374:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/jsc.cpp:374:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/JavaScriptCore/jsc.cpp:375:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/jsc.cpp:377:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/jsc.cpp:378:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/jsc.cpp:378:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/JavaScriptCore/jsc.cpp:379:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/jsc.cpp:380:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/jsc.cpp:381:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/jsc.cpp:382:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/jsc.cpp:383:  Tab found; better to use spaces  [whitespace/tab] [1]
ERROR: Source/JavaScriptCore/tests/stress/regexp-matches-array.js:2:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/tests/stress/regexp-matches-array.js:3:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/tests/stress/regexp-matches-array.js:4:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/tests/stress/regexp-matches-array.js:6:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/tests/stress/regexp-matches-array.js:7:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/tests/stress/regexp-matches-array.js:8:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/tests/stress/regexp-matches-array.js:9:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/tests/stress/regexp-matches-array.js:10:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/tests/stress/regexp-matches-array.js:11:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/tests/stress/runtime-array.js:2:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/tests/stress/runtime-array.js:3:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/tests/stress/runtime-array.js:5:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/tests/stress/runtime-array.js:6:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/tests/stress/runtime-array.js:7:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/tests/stress/runtime-array.js:8:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/tests/stress/runtime-array.js:9:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/tests/stress/runtime-array.js:10:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 41 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Mark Lam]

Comment on attachment 235319 [details]
the patch.

Curses.  Will remove tabs.

[Mark Lam]

Created attachment 235321 [details]
patch minus tabs

[Geoffrey Garen]

Comment on attachment 235321 [details]
patch minus tabs

r=me

[Mark Lam]

Thanks.  Landed in r171390: <http://trac.webkit.org/r171390>.

[Mark Hahnenberg]

(In reply to comment #7)
> Thanks.  Landed in r171390: <http://trac.webkit.org/r171390>.

Did you look at the RegExpArray stuff too?

[Brent Fulgham]

This introduced a build failure on Windows, since NO_RETURN_DUE_TO_CRASH is undefined.

1. I landed a build fix for this: <http://trac.webkit.org/changeset/171393>
2. I of course screwed up the change and had to land a follow-up: <http://trac.webkit.org/changeset/171395>

[Mark Lam]

(In reply to comment #8)
> Did you look at the RegExpArray stuff too?

I believe you mean RegExpMatchesArray.  Yes, we looked at it, and also added a test at Source/JavaScriptCore/tests/stress/regexp-matches-array.js for it.

[Mark Hahnenberg]

(In reply to comment #10)
> (In reply to comment #8)
> > Did you look at the RegExpArray stuff too?
> 
> I believe you mean RegExpMatchesArray.  Yes, we looked at it, and also added a test at Source/JavaScriptCore/tests/stress/regexp-matches-array.js for it.

Sweet! Just curious if there was also an issue there.