Bug 135177 - REGRESSION (r171239): Much more time spent taking snapshots during the PLT
Summary: REGRESSION (r171239): Much more time spent taking snapshots during the PLT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on: 135190
Blocks:
  Show dependency tree / graph
 
Reported: 2014-07-22 14:37 PDT by Tim Horton
Modified: 2014-07-23 03:25 PDT (History)
5 users (show)

See Also:

Attachments
patch (5.05 KB, patch)
2014-07-22 14:43 PDT, Tim Horton 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-07-22 14:37:35 PDT 
We're taking way more snapshots now due to a mistake in r171239.

<rdar://problem/17764847>
Comment 1 Tim Horton 2014-07-22 14:43:28 PDT 
Created attachment 235316 [details]
patch
Comment 2 Tim Horton 2014-07-22 14:47:11 PDT 
http://trac.webkit.org/changeset/171366
Comment 3 Alexey Proskuryakov 2014-07-22 22:53:15 PDT 
This change broke three API tests, so I'm going to roll out.

Tests that failed:
  WKUserContentController.ScriptMessageHandlerWithNavigation
  WebKit2.RestoreSessionStateContainingFormData
Tests that timed out:
  DeviceScaleFactorOnBack.WebKit2
Comment 4 WebKit Commit Bot 2014-07-22 23:00:02 PDT 
Re-opened since this is blocked by bug 135190
Comment 5 Tim Horton 2014-07-23 03:04:54 PDT 
What! How is that possible? I added this message very recently and the *only* thing it does is take a snapshot. Will investigate.
Comment 6 Tim Horton 2014-07-23 03:16:49 PDT 
The UI process is stuck in a HashTable lock adding a string to the AtomicString table under decidePolicyForResponse. Still unclear how I could have influenced this.
Comment 7 Tim Horton 2014-07-23 03:19:03 PDT 
Given http://trac.webkit.org/changeset/171367 I wonder if ap was off-by-one somehow. Testing now.
Comment 8 Tim Horton 2014-07-23 03:23:48 PDT 
Rolling out my patch changes nothing, rolling out Joe's fixes all three tests. gg.
Comment 9 Tim Horton 2014-07-23 03:25:30 PDT 
(In reply to comment #8)
> Rolling out my patch changes nothing, rolling out Joe's fixes all three tests. gg.

Rolled this one back in in http://trac.webkit.org/changeset/171471, will go roll Joe out.