[MSE][Mac] In SourceBufferPrivateAVFObjC::abort(), support reseting parser to the last appended initialization segment.
Created attachment 290022 [details] Patch
rdar://problem/28438637
Comment on attachment 290022 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290022&action=review Looks like you forgot a few files :-) > Source/WebCore/ChangeLog:17 > + and will block until the the previous append() operation completes. Nit: the the > Source/WebCore/ChangeLog:20 > + SourceBufferPrivateAVFObjC to be reset after an abort(), so make that ivar a @property. Rather than passing a Nit: "a @property" -> "an @property"
Created attachment 290026 [details] Patch
Comment on attachment 290026 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=290026&action=review > Source/WebCore/ChangeLog:17 > + and will block until the the previous append() operation completes. Nit: "the the" > Source/WebCore/ChangeLog:20 > + SourceBufferPrivateAVFObjC to be reset after an abort(), so make that ivar a @property. Rather than passing a Nit: "a @property" -> "an @property" > Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:675 > + dispatch_group_wait(m_isAppendingGroup.get(), DISPATCH_TIME_FOREVER); Is it really safe to wait forever?
(In reply to comment #5) > Comment on attachment 290026 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=290026&action=review > > > Source/WebCore/ChangeLog:17 > > + and will block until the the previous append() operation completes. > > Nit: "the the" Ok. > > Source/WebCore/ChangeLog:20 > > + SourceBufferPrivateAVFObjC to be reset after an abort(), so make that ivar a @property. Rather than passing a > > Nit: "a @property" -> "an @property" Ok. > > Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:675 > > + dispatch_group_wait(m_isAppendingGroup.get(), DISPATCH_TIME_FOREVER); > > Is it really safe to wait forever? Now that I think of it, no, it's not. The parsing thread may be blocked on the main thread providing it a AVStreamSession for EME-backed media elements. Apart from that, however, it should be fine.
Created attachment 290034 [details] Patch for landing
Created attachment 290040 [details] Patch for landing
Comment on attachment 290040 [details] Patch for landing Clearing flags on attachment: 290040 Committed r206518: <http://trac.webkit.org/changeset/206518>