RESOLVED FIXED 135131
WebVideoFullscreenInterfaceAVKit leaks AVPlayerViewController 
https://bugs.webkit.org/show_bug.cgi?id=135131
Summary WebVideoFullscreenInterfaceAVKit leaks AVPlayerViewController
Jeremy Jones
Reported 2014-07-21 14:21:59 PDT
WebVideoFullscreenInterfaceAVKit leaks AVPlayerViewController
Attachments
Patch (2.95 KB, patch)
2014-07-21 14:25 PDT, Jeremy Jones 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jeremy Jones
Comment 1 2014-07-21 14:25:40 PDT
Created attachment 235246 [details] Patch
Eric Carlson
Comment 2 2014-07-21 17:40:51 PDT
Comment on attachment 235246 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235246&action=review > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:865 > [m_window setRootViewController:nil]; > [m_playerViewController setDelegate:nil]; > [m_playerViewController setPlayerController:nil]; > + [[m_playerViewController view] removeFromSuperview]; > + [m_playerViewController removeFromParentViewController]; > m_playerViewController = nil; > m_viewController = nil; > m_window = nil; > [m_videoLayer removeFromSuperlayer]; > m_videoLayer = nil; > [m_videoLayerContainer removeFromSuperlayer]; > + [m_videoLayerContainer setPlayerViewController:nil]; > m_videoLayerContainer = nil; Please file a bug to consolidate the duplicate code in invalidate and cleanupFullscreen.
Jon Lee
Comment 3 2014-07-24 21:44:09 PDT
<rdar://problem/17751079>
Note You need to log in before you can comment on or make changes to this bug.