Bug 135131 - WebVideoFullscreenInterfaceAVKit leaks AVPlayerViewController
Summary: WebVideoFullscreenInterfaceAVKit leaks AVPlayerViewController
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-07-21 14:21 PDT by Jeremy Jones
Modified: 2014-07-24 21:44 PDT (History)
9 users (show)

See Also:

Attachments
Patch (2.95 KB, patch)
2014-07-21 14:25 PDT, Jeremy Jones 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2014-07-21 14:21:59 PDT 
WebVideoFullscreenInterfaceAVKit leaks AVPlayerViewController
Comment 1 Jeremy Jones 2014-07-21 14:25:40 PDT 
Created attachment 235246 [details]
Patch
Comment 2 Eric Carlson 2014-07-21 17:40:51 PDT 
Comment on attachment 235246 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235246&action=review

> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:865
>      [m_window setRootViewController:nil];
>      [m_playerViewController setDelegate:nil];
>      [m_playerViewController setPlayerController:nil];
> +    [[m_playerViewController view] removeFromSuperview];
> +    [m_playerViewController removeFromParentViewController];
>      m_playerViewController = nil;
>      m_viewController = nil;
>      m_window = nil;
>      [m_videoLayer removeFromSuperlayer];
>      m_videoLayer = nil;
>      [m_videoLayerContainer removeFromSuperlayer];
> +    [m_videoLayerContainer setPlayerViewController:nil];
>      m_videoLayerContainer = nil;

Please file a bug to consolidate the duplicate code in invalidate and cleanupFullscreen.
Comment 3 Jon Lee 2014-07-24 21:44:09 PDT 
<rdar://problem/17751079>