Bug 135128 - [MSE] YouTube video decode error when variant-switching
Summary: [MSE] YouTube video decode error when variant-switching
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-07-21 13:06 PDT by Jer Noble
Modified: 2014-12-16 13:26 PST (History)
7 users (show)

See Also:

Attachments
Patch (17.96 KB, patch)
2014-07-21 13:16 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (17.57 KB, patch)
2014-07-21 13:31 PDT, Jer Noble 		bfulgham: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2014-07-21 13:06:18 PDT 
[MSE] YouTube video decode error when variant-switching
Comment 1 Jer Noble 2014-07-21 13:16:40 PDT 
Created attachment 235242 [details]
Patch
Comment 2 Jer Noble 2014-07-21 13:17:13 PDT 
<rdar://problem/17740181>
Comment 3 Jer Noble 2014-07-21 13:31:07 PDT 
Created attachment 235243 [details]
Patch
Comment 4 Brent Fulgham 2014-07-21 13:44:30 PDT 
Comment on attachment 235243 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235243&action=review

r=me.

> Source/WebCore/Modules/mediasource/SampleMap.cpp:119
> +    decodeOrder().m_samples.insert(DecodeOrderSampleMap::MapType::value_type(decodeKey, sample));

All this seems a bit verbose, but certainly is fine.
Comment 5 Jer Noble 2014-07-21 13:47:24 PDT 
Committed r171316: <http://trac.webkit.org/changeset/171316>
Comment 6 Jer Noble 2014-12-16 13:26:00 PST 
<rdar://problem/19268991>