Bug 135117 – DatabaseProcess doesn't relaunch after crashing

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Brady Eidson]

DatabaseProcess doesn't relaunch after crashing

It needs to tell its WebContext when it crashes.

<rdar://problem/17717343>

[Brady Eidson]

Created attachment 235222 [details]
Patch v1

[Alexey Proskuryakov]

Comment on attachment 235222 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=235222&action=review

> Source/WebKit2/UIProcess/WebContext.cpp:499
> +    WebContextSupplementMap::const_iterator it = m_supplements.begin();
> +    WebContextSupplementMap::const_iterator end = m_supplements.end();
> +    for (; it != end; ++it)

We can't have a C++11 loop here, can we?

[Brady Eidson]

(In reply to comment #2)
> (From update of attachment 235222 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=235222&action=review
> 
> > Source/WebKit2/UIProcess/WebContext.cpp:499
> > +    WebContextSupplementMap::const_iterator it = m_supplements.begin();
> > +    WebContextSupplementMap::const_iterator end = m_supplements.end();
> > +    for (; it != end; ++it)
> 
> We can't have a C++11 loop here, can we?

Considered it, decided on replicating the pattern used twice before.  Now you've made me go back the other way.  Will change.

[Brady Eidson]

http://trac.webkit.org/changeset/171303

[Darin Adler]

Comment on attachment 235222 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=235222&action=review

>>> Source/WebKit2/UIProcess/WebContext.cpp:499
>>> +    for (; it != end; ++it)
>> 
>> We can't have a C++11 loop here, can we?
> 
> Considered it, decided on replicating the pattern used twice before.  Now you've made me go back the other way.  Will change.

It’s especially good if you use values().

[Brady Eidson]

(In reply to comment #5)
> (From update of attachment 235222 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=235222&action=review
> 
> >>> Source/WebKit2/UIProcess/WebContext.cpp:499
> >>> +    for (; it != end; ++it)
> >> 
> >> We can't have a C++11 loop here, can we?
> > 
> > Considered it, decided on replicating the pattern used twice before.  Now you've made me go back the other way.  Will change.
> 
> It’s especially good if you use values().

That definitely would've been even better than what I landed.