Bug 135108 - [iOS] a Paused media session is not active
Summary: [iOS] a Paused media session is not active
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-07-20 19:43 PDT by Eric Carlson
Modified: 2014-07-21 08:06 PDT (History)
7 users (show)

See Also:

Attachments
Proposed patch (1.53 KB, patch)
2014-07-20 19:57 PDT, Eric Carlson 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2014-07-20 19:43:14 PDT 
MediaSessionManager::hasActive should not return true for a session in the Paused state, we should only activate the AudioSession for Playing sessions.
Comment 1 Eric Carlson 2014-07-20 19:43:48 PDT 
<rdar://problem/17188368>
Comment 2 Eric Carlson 2014-07-20 19:57:56 PDT 
Created attachment 235200 [details]
Proposed patch
Comment 3 Darin Adler 2014-07-20 20:40:07 PDT 
With no regression test, we’re a little vulnerable here. Might be nice to have a brief comment explaining why this function does exactly what it does.
Comment 4 Eric Carlson 2014-07-21 08:05:29 PDT 
(In reply to comment #3)
> With no regression test, we’re a little vulnerable here. Might be nice to have a brief comment explaining why this function does exactly what it does.

Good point. I renamed MediaSessionManager::hasActive to "activeAudioSessionRequired" to make obvious what the method does.
Comment 5 Eric Carlson 2014-07-21 08:06:19 PDT 
Committed r171299 - https://trac.webkit.org/r171299